Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts under tools/ should probably be modified to import a common module. #139

Open
echo-lalia opened this issue Sep 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@echo-lalia
Copy link
Owner

A lot of the scripts under tools/ are re-implementing the same code. This means that when updates are made, the exact same modification needs to be made in several different locations.

Currently, some scripts are import the NON_DEVICE_FILES constant from the parse_files script, but this still feels a little inelegant.

It would make a lot more sense if there was some kind of common build utility module that hosted the logic for things like extracting device files, getting device names, getting default paths, etc.

@echo-lalia echo-lalia added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant