Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to project #9

Closed
alvincrespo opened this issue Oct 30, 2019 · 4 comments · Fixed by #26
Closed

Add linting to project #9

alvincrespo opened this issue Oct 30, 2019 · 4 comments · Fixed by #26
Assignees
Labels
chore enhancement New feature or request

Comments

@alvincrespo
Copy link

We should use our own eslint config: https://github.com/echobind/eslint-plugin-echobind

@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 30, 2019

Does this mean add linting for eb-scripts itself, or so that when users use eb-scripts, it includes our eslintrc for them, under the hood?

Or both?

@cball
Copy link
Member

cball commented Oct 31, 2019

I'd vote for both.

@jsjoeio jsjoeio added chore enhancement New feature or request labels Oct 31, 2019
@alvincrespo
Copy link
Author

I'll separate out the implementation of including our eb-scripts in a developers configuration as a separate issue.

This one was specifically for eb-scripts itself.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 4, 2019

I'll separate out the implementation of including our eb-scripts in a developers configuration as a separate issue.

@alvincrespo created #25

I'll pick up this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants