Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid name mark in Var InOuts Tab Table #372

Open
ShantKhatri opened this issue Aug 9, 2024 · 3 comments
Open

Invalid name mark in Var InOuts Tab Table #372

ShantKhatri opened this issue Aug 9, 2024 · 3 comments

Comments

@ShantKhatri
Copy link
Contributor

The newly created variable's name is always invalid when we create a new InOuts Variable from the "Variable InOuts" tab in the property section.
image

Steps to reproduce

  1. Create New Type
  2. Open created type in workspace
  3. Go to Var InOuts Tab inside Properties
  4. Create New Variable
@bwiesmayr
Copy link
Contributor

So the solution is: when the WITH is missing, there is an error marker
It goes away when you add the WITH. This is mainly a usability bug.

@MartinMelikMerkumians
Copy link
Member

The question is where to put the marker on.

VAR_IN_OUTs always need a WITH due to reasons on how to combine this IEC 61131 feature with the semantics of IEC 61499.
The creation of the error marker itself is on purpose.

@bwiesmayr
Copy link
Contributor

I understand that the creation of the error marker is on purpose, but neither @ShantKhatri nor I managed to resolve the error when we encountered it. We did not get so far as to create a WITH because we thought the tool is trying to tell us that we did something wrong, like invalid name, cannot have varinout in this place ... So some tooltip, showing the error marker on the whole line and not the name, ... could all be possible fixes. The user needs to know what they did wrong (or actually, that they are simply not done yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants