Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

The "ceylon run" command does not understand --verbose subcategories #4813

Closed
CeylonMigrationBot opened this issue Sep 6, 2012 · 19 comments
Closed
Milestone

Comments

@CeylonMigrationBot
Copy link

[@quintesse] The verbose option should handle flags, just like for "ceylon compiler"

[Migrated from ceylon/ceylon-runtime#18]
[Closed at 2014-07-11 11:11:05]

@CeylonMigrationBot
Copy link
Author

[@tombentley] Forgive my ignorance, but what -verbose flags does the existing ceylon command support?

@CeylonMigrationBot
Copy link
Author

[@quintesse] Well to be honest I don't think it does, but it should ;-)
It should have a "cmr" option for example because it uses the same CMR as the compiler does.

@CeylonMigrationBot
Copy link
Author

[@tombentley] Do you see cmr's verbose output as being orthogonal to how it does logging then? Put another way: How does --verbose:foo relate to changing the threshold level of the logging category foo?

@CeylonMigrationBot
Copy link
Author

[@quintesse] I'm not sure, you'd have to see how it's done right now in the compiler, but as far as I remember the logging is normally set at WARN and above, and setting verbose will set it to INFO or DEBUG, not sure which.

@CeylonMigrationBot
Copy link
Author

[@tombentley] I'm asking because it might make sense for the top level tool to configure logging. That would make it easier to do things consistently across tools (e.g. along comes ceylon foo. which also uses CMR, presumably it should also support --verbose=cmr).

@CeylonMigrationBot
Copy link
Author

[@quintesse] Sure, but that seems related to the issue we have open on making the logging more consistent. Now many subsystems have their own way of handling logging and I think it will therefore be (more) difficult to come up with a generic solution until that has been handled.

@CeylonMigrationBot
Copy link
Author

[@tombentley] Isn't this sufficiently tied to the logging issue (#4605 and #482) that it makes more sense to implement it once we've sorted out the logging. I.e.: M5?

@CeylonMigrationBot
Copy link
Author

[@FroMage] Well, without resorting to complex logging, there is already some logging going on in the runtime and enabling it with a flag should be pretty trivial.

@CeylonMigrationBot
Copy link
Author

[@quintesse] Well @tombentley is right in a way, because I was thinking about this some days ago and I doubt there is any logging going on besides the CMR, which is basically the only large component in the runtime. Which means that we'd probably just have one single flag and nothing else. So I agree that we can leave this for M5.

@CeylonMigrationBot
Copy link
Author

[@FroMage] Turning on the logging in the CMR and runtime is a piece of cake: everything important is logged in a special Logger object that we can control.

@CeylonMigrationBot
Copy link
Author

[@quintesse] Sure, but that's the whole point, there isn't anything else. So why go through the trouble of implementing this when probably in M5 we'll need to change it to a new system, all so we can filter out one single message somewhere?

@CeylonMigrationBot
Copy link
Author

[@FroMage] Not sure what you mean. The point is that we would get verbose output for the run tool, which is pretty nice and easy.

@CeylonMigrationBot
Copy link
Author

[@quintesse] We already have verbose output, there are just not any flags like for the compiler (code, ast, cmr, etc etc) because the only flag it would support right now is cmr. So basically --verbose and --verbose=cmr would have 99% the same effect.

@CeylonMigrationBot
Copy link
Author

[@FroMage] The title says "The "ceylon run" command does not understand --verbose", so I assume that the verbose parameter is not even supported, forget the flag. Fixing that should be trivial.

@CeylonMigrationBot
Copy link
Author

[@quintesse] That was done ages ago, the issue is still open for the line below it don't forget that the verbose option should handle flags, just like for "ceylon compiler"

@CeylonMigrationBot
Copy link
Author

[@FroMage] OK then we should update the issue. Moving to M5

@CeylonMigrationBot
Copy link
Author

[@FroMage] M6.

@CeylonMigrationBot
Copy link
Author

[@hwellmann] In Ceylon 1.0.0, the tools docs for ceylon run and ceylon test both state that the --verbose option takes flags, but in fact it doesn't:

$ ceylon run --verbose=cmr hello
ceylon run: Unknown argument: verbose:cmr

Either implement the arguments or delete them from the docs, whatever makes more sense.

@CeylonMigrationBot
Copy link
Author

[@quintesse] With these commits: ceylon/ceylon-common@193721a ceylon/ceylon-compiler@70166f5 fd0be972297fa6d8880061655ec4a7f9daf8679d and 44fd5bee61821b9f358d1c0f9b6f2d4343487331 we can now pass these flags and they'll actually work. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants