Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: pty support not working #101

Open
paul-marechal opened this issue Jun 13, 2019 · 0 comments
Open

mac: pty support not working #101

paul-marechal opened this issue Jun 13, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@paul-marechal
Copy link
Member

paul-marechal commented Jun 13, 2019

Related: #97 (comment)

Tried building on Mac, and there are some issues with the calls made to open a pseudo-terminal. The build process also outputs some warnings, and we get runtime errors when calling the native functions from node.

The issue has to do with the tcgetattr call that fails with Inappropriate ioctl for device, even though when using isatty it returns 1.

When skipping the whole termios cfmakeraw it fails in the JS code that wraps the fd in a net.Socket object.

I tried properly wrapping it by creating read/write streams using the fs module: it removes the runtime errors, but the tests still fail.

I also tried replacing ptsname_r by ttyname_r as suggested by @thegecko, it removes the compilation warnings but we still get runtime errors.

It may require some more knowledge about ttys on OSX, as I am left just trying anything and everything only to eventually fail. I might pick this up again in the future, no guarantees.

@jonahgraham jonahgraham added the help wanted Extra attention is needed label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants