Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation is Premature #171

Open
colin-grant-work opened this issue Jul 20, 2023 · 1 comment
Open

Activation is Premature #171

colin-grant-work opened this issue Jul 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@colin-grant-work
Copy link

At the moment, the plugin uses the activation onStartupFinished. That is likely too broad, and either onCommand or onView activation should be preferred, unless there is specific functionality that must be present even before the user takes trace-related actions.

@colin-grant-work colin-grant-work added the enhancement New feature or request label Jul 20, 2023
@bhufmann
Copy link
Collaborator

bhufmann commented Aug 9, 2023

I think activation onView:traceExplorer.openedTracesView would be sufficient at the moment. Nothing is required before.

VsCode will take care of activating the extension so that other extensions can use the external API of the vscode-trace-extension. For that the other extension just has to make sure that it has it listed as extensionDependencies in the package.json. Otherwise it would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants