Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBI] Upgrade clap version and rust toolchain version #260

Open
3 tasks
ladatz opened this issue Feb 13, 2024 · 0 comments
Open
3 tasks

[PBI] Upgrade clap version and rust toolchain version #260

ladatz opened this issue Feb 13, 2024 · 0 comments

Comments

@ladatz
Copy link
Contributor

ladatz commented Feb 13, 2024

Description

After performing a cargo update, we explicitly set the version of clap to 4.4.18 because version 4.5.0 requires version 1.74 or higher version of rust toolchain. Updating the rust toolchain version has some breaking changes. You can do this using the following command:
cargo update -p [email protected] --precise 4.4.18

See Cargo.lock


 "[[package]]
name = "clap"
version = "4.4.18""

The rust toolchain version should be updated to 1.74 in a later PR.

One example of a breaking change in the newer rust version:
image (1)

Related issue:
Tracking Issue for ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANT future-compat lint · Issue #115010 · rust-lang/rust (github.com)

Acceptance criteria

  • rust toolchain version is updated to 1.74 or higher
  • clap is updated to the latest version
  • Dependencies can be updated as needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant