From 703f5ccd7f68ed462174c2a45e3baf2af735d9ca Mon Sep 17 00:00:00 2001
From: sdawley <sdawley@redhat.com>
Date: Mon, 17 Jul 2023 15:11:41 -0700
Subject: [PATCH] Fix shellcheck errors

---
 build/dockerfiles/import-vsix.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/build/dockerfiles/import-vsix.sh b/build/dockerfiles/import-vsix.sh
index 954e5d2443..5e1839d3c7 100755
--- a/build/dockerfiles/import-vsix.sh
+++ b/build/dockerfiles/import-vsix.sh
@@ -32,7 +32,6 @@ getMetadata(){
     key=$2
 
     # check there is no error field in the metadata and retry if there is
-    max_attempts=5
     for i in 1 2 3 4 5
     do
         vsixMetadata=$(curl -sLS "https://open-vsx.org/api/${vsixName}/${key}")
@@ -86,7 +85,7 @@ for i in $(seq 0 "$((numberOfExtensions - 1))"); do
         # grab metadata for the vsix file
         # if version wasn't set, use latest
         if [[ $vsixVersion == null ]]; then
-            getMetadata $vsixName "latest"
+            getMetadata "${vsixName}" "latest"
             # if version wasn't set in json, grab it from metadata and add it into the file
             # get all versions of the extension
             allVersions=$(echo "${vsixMetadata}" | jq -r '.allVersions')
@@ -96,7 +95,7 @@ for i in $(seq 0 "$((numberOfExtensions - 1))"); do
             resultedVersion=null
             while IFS=$'\t' read -r key value; do
                 # get metadata for the version
-                getMetadata $vsixName $key
+                getMetadata "${vsixName}" "${key}"
       
                 # check if the version is pre-release
                 preRelease=$(echo "${vsixMetadata}" | jq -r '.preRelease')
@@ -132,7 +131,7 @@ for i in $(seq 0 "$((numberOfExtensions - 1))"); do
                 vsixVersion=$resultedVersion
             fi
         else
-            getMetadata $vsixName $vsixVersion
+            getMetadata "${vsixName}" "${vsixVersion}"
         fi 
         
         # extract the download link from the json metadata