che-theia fails with redhat/java8/latest plugin

[vitaliy-guliy]

Describe the bug

It's impossible to properly start a workspace if there is redhat/java8/latest plugin in the devfile.
The bug is reproducible only if build che-theia, based on eclipse-theia/theia/master.

The problem does not depend on the infrastructure and the installation method.

Che version

latest

Steps to reproduce

• Build che-theia image

1. build che-theia:next image, using eclipse-che/che-theia/main and eclipse-theia/theia/master
2. create a minimal devfile, use built che-theia and latest redhat/java8 plugin.
3. start a workspace, open browser console, check errors

You will not be able to see My Workspace and other views, that contributed by plugins. The most of plugins at this point are not properly started.

• Do not build anything, just run prepared devfile

apiVersion: 1.0.0
metadata:
  name: minimal-workspace
projects:
  - name: web-java-spring-petclinic
    source:
      location: 'https://github.com/che-samples/java-spring-petclinic'
      type: git
components:
  - type: cheEditor
    alias: che-theia
    reference: https://gist.githubusercontent.com/vitaliy-guliy/261c8e37493c20d6504701c537a146e0/raw/24606999f923183f992f34d6617f570dd7e0858c/editor.meta.yaml
  - id: redhat/java8/latest
    type: chePlugin

Expected behavior

Plugin system must be working.

Runtime

other (please specify in additional context)

Screenshots

There are few unexpected errors, which could be reason of failure

There is a similar error on che-theia backend

Installation method

other (please specify in additional context)

Environment

Dev Sandbox (workspaces.openshift.com), other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response

[tsmaeder]

I can see the same behavior in the image built for eclipse-che/che-theia#1202. So I assume this is a general problem. We need a hight priority, here.

[azatsarynnyy]

@vitaliy-guliy is it fixed by eclipse-che/che-theia#1205?

[vitaliy-guliy]

@vitaliy-guliy is it fixed by eclipse-che/che-theia#1205?

It's not fixed, but just works with that temporary fix.
I think it's better to wait a bit and check the plugin after solving #20366

[RomanNikitenko]

I investigated the problem and found that:

• according to the recent changes in upstream(https://github.com/eclipse-theia/theia/pull/9538), theia tries to read a package.json file for a vscode extension at starting the IDE
• the path looks like /tmp/vscode-unpacked/redhat.java.latest.toxohserdj.java-0.75.0-60.vsix/extension/package.json for the java extension, for example
• but /tmp/vscode-unpacked/ doesn't exist in theia-ide container, it's present in vscode-java container instead

That's why che-theia fails with a vscode plugin...
I'm looking for a good solution for that problem...

[tsmaeder]

according to the recent changes in upstream, theia tries to read a package.json file for a vscode extension at starting the IDE

Which changes are you referring to?

[RomanNikitenko]

according to the recent changes in upstream, theia tries to read a package.json file for a vscode extension at starting the IDE

Which changes are you referring to?

added the reference to the upstream PR in my comment above

[tsmaeder]

https://github.com/eclipse-theia/theia/pull/9538/files#diff-fafbd64dc9559cdbe8985685e261e5189a336a61cc519e85dce16169baed3334R108 looks fishy to me 🤷

[RomanNikitenko]

https://github.com/eclipse-theia/theia/pull/9538/files#diff-fafbd64dc9559cdbe8985685e261e5189a336a61cc519e85dce16169baed3334R108 looks fishy to me 🤷

it's only the entry point to the failure, but I know exactly the row where it fails, i'm looking for how to fix it...

I think the problem is actual for che-theia only and related to using a different(separate) container for a vscode extension, most likely there is no a use case for the vanilla theia...

[RomanNikitenko]

I created the corresponding images and tested that current issue is going to be fixed by upstream PR https://github.com/eclipse-theia/theia/pull/10087.

Some problems should be fixed by moving che-theia to es2017 eclipse-che/che-theia#1213

But, unfortunately, there is still another problem which I detected and raised here #20366 (comment)
So, I'm debugging that problem...

[azatsarynnyy]

It should be already fixed by eclipse-che/che-theia#1213