Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dds_take vs dds_takecdr #1529

Closed
wjbbupt opened this issue Dec 30, 2022 · 1 comment
Closed

dds_take vs dds_takecdr #1529

wjbbupt opened this issue Dec 30, 2022 · 1 comment

Comments

@wjbbupt
Copy link

wjbbupt commented Dec 30, 2022

I took a look at the interface of c++ package take, using dds_readcdr_impl, c
The version is dds_read_impl, and the difference between these two interfaces is:

  1. The size of max, c++ is 100, and c is the supported input size;
  2. The type of buf, c++ is struct ddsi_serdata, c is void**

My question is: is it because c++ uses the dds_takecdr() interface, and c uses dds_take(); this difference affects the performance and causes the performance of c++ to be worse than that of c;
I hope to get an answer from you. I also want to refactor the c++ packaging interface to narrow the difference between c and c++.

@reicheratwork
Copy link
Contributor

I think this issue is kind of duplicated by CycloneDDS-CXX #358, so in my opinion this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants