Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsSecretsManagerVault does not support endpiont overrides #486

Closed
chlorochrule opened this issue Nov 13, 2024 · 2 comments · Fixed by #485
Closed

AwsSecretsManagerVault does not support endpiont overrides #486

chlorochrule opened this issue Nov 13, 2024 · 2 comments · Fixed by #485
Labels
enhancement New feature or request

Comments

@chlorochrule
Copy link
Contributor

Feature Request

AwsSecretsManagerVaultExtension do not support to override AWS endpoint. I think the option to override AWS endpoint of SecretsManagerClient makes development easier and provides flexibility.

Which Areas Would Be Affected?

Local development, CI, AWS-compatible services: Emulators like localstack are often used in AWS development. However, they require endpoint overrides.

Why Is the Feature Desired?

As mentioned above

Solution Proposal

I already implemented #485
This solution follows S3CoreExtension's implementation

private static final String AWS_ENDPOINT_OVERRIDE = "edc.aws.endpoint.override";

var endpointOverride = Optional.of(AWS_ENDPOINT_OVERRIDE)
.map(key -> context.getSetting(key, null))
.map(URI::create)
.orElse(null);

@github-actions github-actions bot added the triage all new issues awaiting classification label Nov 13, 2024
Copy link

Thanks for your contribution 🔥 We will take a look asap 🚀

@paullatzelsperger paullatzelsperger added enhancement New feature or request and removed triage all new issues awaiting classification labels Nov 26, 2024
@paullatzelsperger
Copy link
Member

paullatzelsperger commented Nov 26, 2024

@chlorochrule removed the triage label. Can you check if this relates to #490?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants