Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grizzly does not build against Servlet 6.1.0-M1 #2205

Open
lukasj opened this issue Mar 20, 2024 · 8 comments
Open

Grizzly does not build against Servlet 6.1.0-M1 #2205

lukasj opened this issue Mar 20, 2024 · 8 comments

Comments

@lukasj
Copy link
Member

lukasj commented Mar 20, 2024

[ERROR] .../org/glassfish/grizzly/servlet/HttpServletResponseImpl.java:[48,8] org.glassfish.grizzly.servlet.HttpServletResponseImpl is not abstract and does not override abstract method sendRedirect(java.lang.String,int,boolean) in jakarta.servlet.http.HttpServletResponse
@lukasj
Copy link
Member Author

lukasj commented Mar 26, 2024

@arjantijms nor M2 - both are missing sendRedirect(java.lang.String,int,boolean) method in org.glassfish.grizzly.servlet.HttpServletResponseImpl - in 4.0.2

@arjantijms
Copy link
Contributor

@lukasj This commit from a while ago should have fixed that:

#2209

@arjantijms
Copy link
Contributor

You should then try with 4.1.0-M1, not 4.0.2.

@lukasj
Copy link
Member Author

lukasj commented Jun 25, 2024

that commit went to the main branch and the default one is master. What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

...to answer the 4.1.0-M1 - yes, this version works fine for me.

@arjantijms
Copy link
Contributor

What is the point of having main the master without actually renaming the master to main and keeping both branches? Isn't it confusing?

Still work to be done indeed. It's done now via the self service thing, and I still need to find out where it resides and how it works.

@arjantijms
Copy link
Contributor

...to answer the 4.1.0-M1 - yes, this version works fine for me.

\o/ thanks!

@arjantijms
Copy link
Contributor

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

@dmatej
Copy link
Contributor

dmatej commented Jul 6, 2024

Also, maybe we need to move Grizzly to the GlassFish project or I need to nominate some other committers. It seems that now I'm the last active committer there.

I can join you, I already did some work on Grizzly: https://github.com/eclipse-ee4j/grizzly/issues?q=author%3Admatej
If I remember well, when I was working for Payara I also fixed some h2spec tests. Seems those changes are missing in this repo, I have to check ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants