Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicAuthenticationMechanism: Unable to use passwords with colon #250

Open
hneubauer opened this issue Jun 28, 2019 · 1 comment
Open

BasicAuthenticationMechanism: Unable to use passwords with colon #250

hneubauer opened this issue Jun 28, 2019 · 1 comment
Assignees
@ggam
Milestone
Futures

Comments

@hneubauer
Copy link

There seems to be a bug for me in the BasicAuthenticationMechanism. It's not possible to get the correct credentials if the password contains a colon in it.

The split in the getCredentials method can produce more than two parts and ultimately removes colons from passwords. The password 1234:5678 then becomes the password 1234.
@ggam ggam self-assigned this Jun 28, 2019
@ggam ggam added this to the 1.1 milestone Jun 28, 2019
ggam added a commit to ggam/soteria that referenced this issue Jun 28, 2019
@ggam
Fixes eclipse-ee4j#250
9cd10b6
ggam added a commit to ggam/soteria that referenced this issue Jun 28, 2019
@ggam
Fixes eclipse-ee4j#250
dfab7ad 
Modified test
@ggam
Copy link
Member

ggam commented Jun 28, 2019

Nice catch, thanks! I've created #251 to fix this. Could you please verify that patch solves your issue?

ggam added a commit to ggam/soteria that referenced this issue Jul 10, 2019
@ggam
Fixes eclipse-ee4j#250
2c21f6e 
Modified test

Signed-off-by: Guillermo González de Agüero <[email protected]>
@keilw keilw modified the milestones: 1.1, Futures Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggam ggam

Labels
None yet
Projects
None yet
Milestone
Futures
Development

No branches or pull requests
3 participants
@keilw @ggam @hneubauer