From eea32dd573f054c9b7f948bbae5febfae3fa7428 Mon Sep 17 00:00:00 2001
From: Jonah Graham <jonah@kichwacoders.com>
Date: Thu, 7 Jan 2021 21:21:55 -0500
Subject: [PATCH] Bug #459 Add a target file for Embed CDT

Using a target file enables a way to share consistent plug-ins in
the runtime Eclipse instance across developers and ensures that
the target platform that Maven Tycho uses is the same as what is
used in Eclipse.

There is no requirement to use the target platform in the IDE, the
current method of installing all the dependencies in the development
Eclipse instance is ok.
---
 parent/pom.xml                                | 24 +++++++----------
 pom.xml                                       |  1 +
 ...rg.eclipse.embedcdt.target-platform.target | 15 +++++++++++
 target-platform/pom.xml                       | 27 +++++++++++++++++++
 4 files changed, 52 insertions(+), 15 deletions(-)
 create mode 100644 target-platform/org.eclipse.embedcdt.target-platform.target
 create mode 100644 target-platform/pom.xml

diff --git a/parent/pom.xml b/parent/pom.xml
index 3fc7361b8..3bd6d1f4f 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -63,21 +63,6 @@
 		</license>
 	</licenses>
 
-	<repositories>
-		<repository>
-			<id>eclipse</id>
-			<layout>p2</layout>
-			<!-- Explicit reference to 2020-09 with CDT 10.0.0 -->
-			<!-- (Do a run without version and retain the most recent one) -->
-			<!-- <url>https://download.eclipse.org/releases/neon/201705151400/</url> -->
-			<url>https://download.eclipse.org/releases/2020-09/202009161000/</url>
-		</repository>
-		<repository>
-			<id>license-feature</id>
-			<url>http://download.eclipse.org/cbi/updates/license/</url>
-			<layout>p2</layout>
-		</repository>
-	</repositories>
 	<pluginRepositories>
 		<pluginRepository>
 			<!-- Eclipse provided plug-ins for signing JARs with Eclipse infra -->
@@ -145,6 +130,15 @@
 							<arch>x86_64</arch>
 						</environment>
 					</environments>
+
+					<!-- Use the same target file that can be used within Eclipse -->
+					<target>
+						<artifact>
+							<groupId>org.eclipse.embedcdt</groupId>
+							<artifactId>org.eclipse.embedcdt.target-platform</artifactId>
+							<version>6.1.0-SNAPSHOT</version>
+						</artifact>
+					</target>
 				</configuration>
 			</plugin>
 			<plugin>
diff --git a/pom.xml b/pom.xml
index 942d42856..f4f08cbf7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -87,6 +87,7 @@
 		<module>features/org.eclipse.embedcdt.doc.user-feature</module>
 
 		<module>repositories/org.eclipse.embedcdt-repository</module>
+		<module>target-platform</module>
 
 		<!-- Arm specific modules. -->
 		<module>branding/org.eclipse.embedcdt.managedbuild.cross.arm-branding</module>
diff --git a/target-platform/org.eclipse.embedcdt.target-platform.target b/target-platform/org.eclipse.embedcdt.target-platform.target
new file mode 100644
index 000000000..df7d969a0
--- /dev/null
+++ b/target-platform/org.eclipse.embedcdt.target-platform.target
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<?pde version="3.8"?>
+<target name="embedcdt">
+	<locations>
+		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
+			<repository location="https://download.eclipse.org/releases/2020-09/202009161000"/>
+			<unit id="org.eclipse.cdt.feature.group" version="0.0.0"/>
+			<unit id="org.eclipse.cdt.debug.gdbjtag.feature.group" version="0.0.0"/>
+		</location>
+		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
+			<repository location="http://download.eclipse.org/cbi/updates/license/"/>
+			<unit id="org.eclipse.license.feature.group" version="0.0.0"/>
+		</location>
+	</locations>
+</target>
\ No newline at end of file
diff --git a/target-platform/pom.xml b/target-platform/pom.xml
new file mode 100644
index 000000000..01ddbdc0b
--- /dev/null
+++ b/target-platform/pom.xml
@@ -0,0 +1,27 @@
+<!--
+  Copyright (c) 2021 Kichwa Coders Canada Inc.
+  This program and the accompanying materials
+  are made available under the terms of the Eclipse Public License 2.0
+  which accompanies this distribution, and is available at
+  https://www.eclipse.org/legal/epl-2.0/
+  
+  SPDX-License-Identifier: EPL-2.0
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+		xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<parent>
+		<groupId>org.eclipse.embedcdt</groupId>
+		<artifactId>org.eclipse.embedcdt.parent</artifactId>
+		<version>6.1.0-SNAPSHOT</version>
+		<relativePath>../parent/pom.xml</relativePath>
+	</parent>
+
+	<groupId>org.eclipse.embedcdt</groupId>
+	<artifactId>org.eclipse.embedcdt.target-platform</artifactId>
+	<version>6.1.0-SNAPSHOT</version>
+	<packaging>eclipse-target-definition</packaging>
+
+</project>