Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings #458

Open
jonahgraham opened this issue Dec 7, 2020 · 1 comment
Open

Cleanup warnings #458

jonahgraham opened this issue Dec 7, 2020 · 1 comment
Assignees

Comments

@jonahgraham
Copy link
Contributor

The embedcdt plug-ins are quite close to warning free. I think a little push can get us there, or close enough to make it easish to tell there are warnings.

There are four cases of warnings I see that cover most of the warnings

  • lots of warnings in liqp - If this was moved into a new bundle, the warnings for this bundle could be set to info. This requires .settings to be checked in though.
  • lots of provisional API usage - This can be solved in two ways - one create the usage problem filters (requires .settings/.api_filters to be checked in) and the better way is for CDT (and others) to mark this provisional API that has been provisional for 10+ years to be no longer provisional anymore!
  • lots of warnings about progress monitors - to fix this requires moving to the newer progress monitor API. There is quite a good write up on the new API and how to migrate here https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
  • Unknown referenced nature: org.eclipse.m2e.core.maven2Nature - This one happens because I don't follow https://eclipse-embed-cdt.github.io/develop/build-prerequisites/ precisely, specifically I don't use the m2e plug-ins for Eclipse when I am developing Eclipse plug-ins and using Tycho.

That would get down to ~40ish warnings which would be great.

I think the above would make good first issues for new contributors.

@ilg-ul
Copy link
Contributor

ilg-ul commented Dec 7, 2020

specifically I don't use the m2e plug-ins for Eclipse when I am developing Eclipse plug-ins and using Tycho.

You do not follow the steps in the build-prerequisites page because they are not correct? If you have a better configuration, we should improve the web page.

Otherwise I think that it would be better for you to have a separate Eclipse and a separate workspace, installed exactly as documented, so we can have a consistent way of spotting errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants