iox-#1613 Remove EXPECT_DEATH

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. Assign PR to reviewer

Notes for Reviewer

This PR replaces the last remaining EXPECT_DEATH with IOX_EXPECT_FATAL_FAILURE where feasible. There are a few remaining occurrences which cannot be replaced, e.g. tests for PoshRuntime which has a singleton. These tests now use GTEST_FLAG(death_test_style) = "threadsafe"; to prevent stucking threads.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Remove EXPECT_DEATH #1613
• Closes MacOS tests that use EXPECT_DEATH stuck #898

[elBoberido]

I just discovered that the logger currently does not invoke implicit conversion of greater_or_equal<T> to T correctly due to SFINEA on LogStream& operator<<(const T value) for arithmetic typs. LogStream& operator<<(const bool value) does not have SFINEA so greater_or_equal<uint32> gets implicitly converted into bool. I guess we should replace the SFINEA implementation for arithmetic types with explicit methods.

[FerdinandSpitzschnueffler]

@elBoberido Can you please open an issue for this?

[elBoberido]

@FerdinandSpitzschnueffler I added a task to #1755

[codecov]

Codecov Report

Merging #2019 (5aae57e) into master (e70767a) will increase coverage by 0.08%.
Report is 10 commits behind head on master.
The diff coverage is 64.73%.

❗ Current head 5aae57e differs from pull request most recent head 4ea848e. Consider uploading reports for the commit 4ea848e to get more accurate results

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
+ Coverage   74.17%   74.26%   +0.08%     
==========================================
  Files         415      413       -2     
  Lines       16102    16055      -47     
  Branches     2254     2246       -8     
==========================================
- Hits        11944    11923      -21     
+ Misses       3435     3411      -24     
+ Partials      723      721       -2     

Flag	Coverage Δ
unittests	74.05% <64.73%> (+0.08%)	⬆️
unittests_timing	15.25% <27.80%> (+0.34%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...include/iceoryx_dust/internal/cxx/forward_list.inl	0.00% <0.00%> (ø)
...ude/iceoryx_hoofs/internal/posix_wrapper/mutex.hpp	100.00% <ø> (ø)
iceoryx_hoofs/source/posix_wrapper/mutex.cpp	41.35% <ø> (-4.18%)	⬇️
.../posix_wrapper/shared_memory_object/memory_map.cpp	30.18% <ø> (+0.55%)	⬆️
...ude/iceoryx_posh/internal/mepoo/shared_pointer.hpp	100.00% <ø> (ø)
...ude/iceoryx_posh/internal/mepoo/typed_mem_pool.inl	82.85% <ø> (ø)
...ceoryx_dust/source/posix_wrapper/message_queue.cpp	61.90% <28.57%> (-1.37%)	⬇️
iceoryx_dust/source/posix_wrapper/named_pipe.cpp	49.43% <57.97%> (+0.40%)	⬆️
..._hoofs/source/posix_wrapper/unix_domain_socket.cpp	59.75% <63.10%> (+1.00%)	⬆️
...ude/iceoryx_posh/internal/mepoo/shared_pointer.inl	90.00% <71.42%> (+1.90%)	⬆️
... and 8 more

... and 2 files with indirect coverage changes

[mossmaurice]

LGTM, thanks for the PR! If you create the follow-up issue for the SFINAE thingy we can merge this.

[elBoberido]

@mossmaurice I added a task to #1755