Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDTLS should announce inlay hint support with 'inlayHintProvider': true #2365

Closed
LDAP opened this issue Dec 7, 2022 · 3 comments · Fixed by #2496
Closed

JDTLS should announce inlay hint support with 'inlayHintProvider': true #2365

LDAP opened this issue Dec 7, 2022 · 3 comments · Fixed by #2496
Labels
protocol
Milestone
Mid March 2023

Comments

@LDAP
Copy link

LDAP commented Dec 7, 2022

JDTLS currently does not announce its inlay hint support in initializeResult.

Announcing inlay hints would make inlay hints work in other editors than VSCode without special handling. Inlay hints work in VSCode because the requests are manually sent in inlayHintsProvider.ts.
@jdneo
Copy link
Contributor

jdneo commented Dec 8, 2022 •
edited
Loading

We can do that after we update the LSP4J's version. The current used version does not have native support for inlay hint.

Related: #2348

// cc @rgrunber

@jdneo jdneo added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@mfussenegger
Copy link
Contributor

It would also be nice if it additionally checked the client capability for the inlayHint refresh, currently this results in warning entries in the log with neovim because it doesn't implement inlay hints yet

LDAP added a commit to sublimelsp/LSP-jdtls that referenced this issue Dec 18, 2022
@LDAP
Workaround for eclipse-jdtls/eclipse.jdt.ls/issues/2365
320929b
@bhankas
Copy link

bhankas commented Feb 25, 2023

Since #2348 is now merged and closed, are there any more blockers?

@jdneo jdneo mentioned this issue Feb 27, 2023
Merged
@jdneo jdneo added protocol and removed dependencies Pull requests that update a dependency file labels Feb 27, 2023
@jdneo jdneo added this to the Mid March 2023 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol
Projects
None yet
Milestone
Mid March 2023
Development

Successfully merging a pull request may close this issue.

Check the client capability for inlay hints jdneo/eclipse.jdt.ls
4 participants
@mfussenegger @jdneo @LDAP @bhankas