Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include build and test execution for PRs #372

Open
eliasnogueira opened this issue Apr 24, 2023 · 2 comments
Open

Include build and test execution for PRs #372

eliasnogueira opened this issue Apr 24, 2023 · 2 comments

Comments

@eliasnogueira
Copy link
Contributor

Which JNoSQL project the issue refers to?

JNoSQL (Core)

Use case

Context

We expect people to contribute to the JNOSQL project.
When they submit a PR, we expect that all the tests are run, even in the not touched modules to guarantee the project's reliability.

Currently, there's no test running when a PR is open.

Feature proposal

The proposal is to include the build and test process when a contributor opens a PR, even if it will run again during the merge process.

This will prevent a possible long feedback loop to fix possible issues.

@otaviojava
Copy link
Contributor

otaviojava commented Apr 24, 2023

Hey @eliasnogueira
Check your latest PR:
#369

We're running both Java 17 and 20.
Once it is on Eclipse Foundation availability nodes, it takes some time to start to run.

Screenshot from 2023-04-24 16-26-05

@eliasnogueira
Copy link
Contributor Author

@otaviojava maybe we can do this targeting only one Java version in the PR process.
Another possible solution would tag the necessary tests/modules to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants