Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove false extension points #4170

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

dseurotech
Copy link
Contributor

@dseurotech dseurotech commented Jan 13, 2025

TBD

Brief description of the PR.
[e.g. Added null check on object to avoid NullPointerException]

Related Issue
This PR fixes/closes {issue number}

Description of the solution adopted
A more detailed description of the changes made to solve/close one or more issues.
If the PR is simple and easy to understand this section can be skipped.

Screenshots
If applicable, add screenshots to help explain your solution

Any side note on the changes made
Description of any other change that has been made, which is not directly linked to the issue resolution
[e.g. Code clean up/Sonar issue resolution]

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 38.50932% with 198 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (d795152) to head (d53f77d).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...pse/kapua/commons/service/internal/ServiceDAO.java 0.00% 56 Missing ⚠️
.../kapua/service/datastore/steps/DatastoreSteps.java 0.00% 43 Missing ⚠️
...kapua/commons/rest/filters/CORSResponseFilter.java 0.00% 8 Missing ⚠️
...kapua/model/query/KapuaForwardableEntityQuery.java 50.00% 5 Missing and 1 partial ⚠️
...service/event/store/api/EventStoreRecordQuery.java 0.00% 5 Missing ⚠️
.../app/api/resources/v1/resources/JobExecutions.java 0.00% 5 Missing ⚠️
...pua/service/account/steps/AccountServiceSteps.java 0.00% 5 Missing ⚠️
...onfiguration/AbstractKapuaConfigurableService.java 0.00% 4 Missing ⚠️
...service/internal/KapuaNamedEntityServiceUtils.java 0.00% 4 Missing ⚠️
...urces/v1/resources/DeviceManagementOperations.java 0.00% 4 Missing ⚠️
... and 41 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4170      +/-   ##
=============================================
- Coverage      16.71%   16.57%   -0.14%     
  Complexity        22       22              
=============================================
  Files           2039     2020      -19     
  Lines          53018    52846     -172     
  Branches        4453     4454       +1     
=============================================
- Hits            8860     8759     -101     
+ Misses         43755    43684      -71     
  Partials         403      403              
Files with missing lines Coverage Δ
.../java/org/eclipse/kapua/commons/CommonsModule.java 76.19% <ø> (-1.09%) ⬇️
...service/event/store/api/EventStoreXmlRegistry.java 50.00% <ø> (+16.66%) ⬆️
...ce/event/store/internal/EventStoreFactoryImpl.java 100.00% <ø> (ø)
...re/internal/EventStoreRecordImplJpaRepository.java 100.00% <100.00%> (ø)
...ua/commons/service/internal/cache/EntityCache.java 22.78% <ø> (ø)
...ob/engine/queue/QueuedJobExecutionXmlRegistry.java 0.00% <ø> (ø)
.../kapua/app/api/web/RestApiJAXBContextProvider.java 0.00% <ø> (ø)
.../kapua/service/account/xml/AccountXmlRegistry.java 50.00% <ø> (+12.50%) ⬆️
...a/service/account/internal/AccountFactoryImpl.java 10.00% <ø> (+1.66%) ⬆️
...ice/account/internal/AccountImplJpaRepository.java 25.00% <100.00%> (ø)
... and 63 more

... and 256 files with indirect coverage changes

@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch 9 times, most recently from 7d7c2cb to 9c92f15 Compare January 17, 2025 16:46
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch 6 times, most recently from 785eb8e to a503aa2 Compare January 27, 2025 12:54
@dseurotech dseurotech changed the title 💥 KapuaListResult is now concrete, as are all subclasses (needed… Remove false extension points Jan 27, 2025
@dseurotech dseurotech changed the title Remove false extension points 💥 Remove false extension points Jan 27, 2025
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch 12 times, most recently from cd6b9cb to d7bac90 Compare January 31, 2025 14:04
… to provide xml annotations), avoiding the split between interfaces and implementations

Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch from d7bac90 to d2675ac Compare January 31, 2025 14:13
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch 3 times, most recently from 987dc69 to b241437 Compare February 4, 2025 14:16
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch 3 times, most recently from b5ea7ed to d417835 Compare February 5, 2025 15:26
@dseurotech dseurotech force-pushed the ref-remove_false_extension_points branch from d417835 to 68de730 Compare February 5, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant