Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce isolation of package exports #1261

Closed
spoenemann opened this issue Nov 3, 2023 · 2 comments · Fixed by #1269
Closed

Enforce isolation of package exports #1261

spoenemann opened this issue Nov 3, 2023 · 2 comments · Fixed by #1269
Labels
polish Some feature needs improvement
Milestone
v3.0.0

Comments

@spoenemann
Copy link
Contributor

It would be great to enforce that the main export of the langium package doesn't have any transitive dependencies to code from test, grammar (#1171) and lsp (#1258).

Can we write a test to detect such unwanted dependencies?
@spoenemann spoenemann added the polish Some feature needs improvement label Nov 3, 2023
@kaisalmen
Copy link
Contributor

kaisalmen commented Nov 3, 2023 •
edited
Loading

Idea: Bundlers (e.g. rollup) do module graph analysis. We could use a plugin to access that graph and perform analysis / search / identification.

@spoenemann spoenemann mentioned this issue Nov 6, 2023
Merged
@spoenemann
Copy link
Contributor Author

I found a simple solution in #1269.

@spoenemann spoenemann added this to the v3.0.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
polish Some feature needs improvement
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Added validate-exports script to check the consistency of package exports spoenemann/langium
2 participants
@spoenemann @kaisalmen