From 7f7e0141f1e73214cbed88eae817d90cdec8b5ba Mon Sep 17 00:00:00 2001 From: Christian Dietrich Date: Thu, 16 Jan 2025 07:30:14 +0100 Subject: [PATCH 1/2] added .nvmrc Signed-off-by: Christian Dietrich --- .nvmrc | 1 + 1 file changed, 1 insertion(+) create mode 100644 .nvmrc diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 000000000..3c032078a --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +18 From b7af14b5bfc11d1b208c33f4c36ab2d57066db15 Mon Sep 17 00:00:00 2001 From: Christian Dietrich Date: Mon, 20 Jan 2025 15:04:10 +0100 Subject: [PATCH 2/2] review feedback --- .github/workflows/actions.yml | 8 ++++---- .github/workflows/docs.yml | 2 +- .github/workflows/publish.yml | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index ec50abe08..7cf0e352c 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -21,9 +21,9 @@ jobs: - name: Checkout uses: actions/checkout@v3 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version-file: '.nvmrc' - name: Build shell: bash run: | @@ -43,9 +43,9 @@ jobs: - name: Checkout uses: actions/checkout@v3 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version-file: '.nvmrc' - name: Build shell: bash run: | diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index eecd1bd62..2432adf8f 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -22,7 +22,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version-file: '.nvmrc' - name: Build API docs run: | npm ci diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 61d6e4d2f..8a5393628 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -16,9 +16,9 @@ jobs: - name: Checkout uses: actions/checkout@v3 - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18.x' + node-version-file: '.nvmrc' registry-url: 'https://registry.npmjs.org' - name: Build shell: bash