Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of default accessibility makes code duplication necessary #2153

Open
mor-n4 opened this issue Jun 22, 2021 · 0 comments
Open

Handling of default accessibility makes code duplication necessary #2153

mor-n4 opened this issue Jun 22, 2021 · 0 comments
Labels

Comments

@mor-n4
Copy link
Contributor

mor-n4 commented Jun 22, 2021

The computation of a type's / member's actual accessibility in cases no accessibility modifier was declared in the source code is done in the types model (i.e. Types.xcore in methods #getTypeAccessModifier() and #getMemberAccessModifier()). This means that without a type model element, e.g. only on the basis of the AST, it is not possible to reuse this logic, forcing developers to duplicate it.

The goal of this user story is to

  1. refactor the above computation of default accessibility to make it reusable and
  2. adjust all places in the code where this logic has already been copied.
    Search code for GH-2153 to find some places (not complete!).
@mor-n4 mor-n4 added the bug label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant