Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance test for doi manuscript pdf service #1004

Closed
markpatton opened this issue Jul 8, 2024 · 4 comments · Fixed by eclipse-pass/pass-acceptance-testing#23
Closed
Assignees
Labels
Milestone

Comments

@markpatton
Copy link
Contributor

What?

The pass-ui interaction usage of the DOI service which returns available pdfs should have an acceptance test.

Why?

We missed updating the calls to the doi service for CSRF protection by the ui because of a lack of testing.

How?

Acceptance Criteria

A dedicated acceptance test.

Related Issues

@markpatton markpatton added the UI label Jul 8, 2024
@markpatton markpatton added this to the 1.9.0 milestone Jul 8, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Jul 8, 2024
@dkriethof dkriethof modified the milestones: 1.9.0, 1.10.0 Jul 30, 2024
@dkriethof dkriethof moved this from Backlog to Ready for Development in Eclipse PASS Jul 30, 2024
@dkriethof dkriethof modified the milestones: 1.10.0, 1.11.0 Aug 27, 2024
@rpoet-jh rpoet-jh self-assigned this Sep 3, 2024
@rpoet-jh rpoet-jh moved this from Ready for Development to In Progress in Eclipse PASS Sep 3, 2024
@rpoet-jh
Copy link
Contributor

rpoet-jh commented Sep 3, 2024

@rpoet-jh
Copy link
Contributor

rpoet-jh commented Sep 3, 2024

@markpatton or maybe you are referring to the Files step where the calls to the DOI service are made for manuscript?

@rpoet-jh
Copy link
Contributor

rpoet-jh commented Sep 3, 2024

I also wanted to confirm a doubt I have. I ran a test locally using pass-docker. I entered DOI 10.1039/c7an01256j. I got to the Files step, and I see this request being made http://localhost:8080/doi/manuscript?doi=10.1039/c7an01256j, and it returns:


    {
        "url": "https://europepmc.org/articles/pmc6759371?pdf=render",
        "repositoryLabel": "PubMed Central - Europe PMC",
        "type": "application/pdf",
        "source": "Unpaywall",
        "name": "pmc6759371?pdf=render",
        "isBest": true
    },
    {
        "url": null,
        "repositoryLabel": null,
        "type": "application/pdf",
        "source": "Unpaywall",
        "name": null,
        "isBest": false
    }
]

Based on the code I see in the UI, I think the UI should show the pmc6759371?pdf=render manuscript PDF, but it displays this message instead: We could not find any existing open access copies for your manuscript/article. Please upload your own copy.

@markpatton
Copy link
Contributor Author

markpatton commented Sep 4, 2024

@rpoet-jh Right, I was referring the Files step in particular. I also have observed the same behavior of the ui not seeming to do the right thing. I had meant to make a separate ticket.

@rpoet-jh rpoet-jh moved this from In Progress to Peer Review/QA in Eclipse PASS Sep 5, 2024
@github-project-automation github-project-automation bot moved this from Peer Review/QA to Done in Eclipse PASS Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants