Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check spring boot maven plugin repackage config #1005

Closed
rpoet-jh opened this issue Jul 9, 2024 · 0 comments · Fixed by eclipse-pass/pass-support#125
Closed

Check spring boot maven plugin repackage config #1005

rpoet-jh opened this issue Jul 9, 2024 · 0 comments · Fixed by eclipse-pass/pass-support#125
Assignees
Milestone

Comments

@rpoet-jh
Copy link
Contributor

rpoet-jh commented Jul 9, 2024

What?

Check the spring-boot-maven-plugin repackage configuration in the pass-support and pass-core pom.xml to ensure they align with the documentation: https://docs.spring.io/spring-boot/docs/3.2.1/maven-plugin/reference/htmlsingle/#packaging.examples.custom-name . Specifically, check the elements in the configuration element.

Note that the spring boot jar files are being repackaged correctly now, but the current config is slightly different than the recommended config based on the docs.

Why?

Change our config so it matches recommendations in the docs.

How?

Read the docs and make any needed changes.

Acceptance Criteria

Config aligns with docs and build spring boot jar files with required name.

@rpoet-jh rpoet-jh converted this from a draft issue Jul 9, 2024
@rpoet-jh rpoet-jh self-assigned this Aug 23, 2024
@rpoet-jh rpoet-jh moved this from Backlog to In Progress in Eclipse PASS Aug 23, 2024
@rpoet-jh rpoet-jh added this to the 1.10.0 milestone Aug 23, 2024
@rpoet-jh rpoet-jh linked a pull request Aug 26, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Peer Review/QA to Done in Eclipse PASS Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant