Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 produces Whitelabel Error Page with stacktrace #1062

Closed
rpoet-jh opened this issue Oct 9, 2024 · 2 comments · Fixed by eclipse-pass/pass-core#95
Closed

404 produces Whitelabel Error Page with stacktrace #1062

rpoet-jh opened this issue Oct 9, 2024 · 2 comments · Fixed by eclipse-pass/pass-core#95
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rpoet-jh
Copy link
Contributor

rpoet-jh commented Oct 9, 2024

Environment

PROD

Date/time occurred

2024-10-09 10:30a

Description

Typing an invalid path on PASS produces the default Whitelabel Error Page with stacktrace.

Steps to Reproduce

Log into https://app.pass.jhu.edu/
In the browser address bar, type https://app.pass.jhu.edu/foobar
You'll see the Whitelabel Error Page with stacktrace

Expected Results

A standard error page should be returned for invalid paths without stacktrace. Note that if the path has /app, then it is good, this is just an issue when /app is not in the path.

Actual Results

Default error page is returned which contains stacktrace which is not recommended.

Evidence

Estimated Severity

Major

@rpoet-jh rpoet-jh added the bug Something isn't working label Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Oct 9, 2024
@rpoet-jh rpoet-jh added this to the 1.12.0 milestone Oct 9, 2024
@rpoet-jh rpoet-jh self-assigned this Oct 9, 2024
@rpoet-jh rpoet-jh moved this from Ready for Development to In Progress in Eclipse PASS Oct 9, 2024
@rpoet-jh
Copy link
Contributor Author

server.error.whitelabel.enabled=false has been set in jhu stage and prod to disable whitelabel error page. Now error page looks like:

Image

We should configure a more "user friendly" error page.

@markpatton
Copy link
Contributor

When /app/ is in the path, then the error page is handled by pass-ui. Otherwise it is handled by pass-core and we can add whatever default error page we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants