Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user proxy submission link click throws an error #1094

Open
jaredgalanis opened this issue Aug 13, 2020 · 1 comment
Open

New user proxy submission link click throws an error #1094

jaredgalanis opened this issue Aug 13, 2020 · 1 comment
Labels

Comments

@jaredgalanis
Copy link
Contributor

jaredgalanis commented Aug 13, 2020

I found one issue that I think probably exists already and that we may not be able to do much about or reproduce very easily.

I had a long-lived browser session where I was unable to successfully log out of PASS. When I tried a new user proxy sub and clicked the link in the email, the application threw an error when loading the submissions detail page.

The error appears to be a 413 coming from one of the elastic search queries on the submissions detail route model hook, but it's unclear why this would happen in some cases and not in others.

https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers

I could not repro this in a fresh Firefox window and I also can no longer reproduce it in Chrome after having quit the application entirely.

Given an inability to reliably reproduce this when freshly authenticated, I think likely has to do with some quirks of our authentication strategy that we don’t control.

I will continue to monitor it and will write an issue for it, but after speaking with @jabrah , neither of us believe this is tied to the Octane upgrade branch work.

Screen Shot 2020-08-13 at 2 47 33 PM

@jaredgalanis
Copy link
Contributor Author

There is actually also a different manifestation, which may be an entirely separate issue, that occurs when clicking a new proxy user submission link.

In this error the user service is unable to match the new proxy user email with the submitter email on the submission (in this case it complains about nullness).

I have most reliably reproduced this error when fully logged out of PASS and attempting to visit the link.

Screen Shot 2020-08-14 at 10 59 14 AM

@esm here is the har file we discussed (github made me zip it to attach here):

demo.pass.library.jhu.edu.har.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant