3 tests failing in Test_org_eclipse_swt_browser_Browser #1564

fedejeanne · 2024-10-30T14:20:45Z

The problem

It is not possible to open a child browser with newer versions of WebKit.

How to reproduce

The problem can be reproduced in Ubuntu 24.04 (tested using WSL2) with WebKit 2.46

Install the proper version of WebKit with this command:

VERSION=2.46.3-0ubuntu0.24.04.1 && sudo apt-get install libwebkitgtk-6.0-4=${VERSION} libjavascriptcoregtk-6.0-1=${VERSION}

Run this snippet:

Snippet

public class OpenChildBrowser {
	public static void main(String[] args) {
		Display display = new Display();
		final Shell shell = new Shell(display);
		shell.setLayout(new FillLayout());
		final Browser browser = new Browser(shell, SWT.NONE);
		Shell childShell = new Shell(shell, SWT.None);
		childShell.setText("Child shell");
		childShell.setLayout(new FillLayout());
		final Browser browserChild = new Browser(childShell, SWT.NONE);
		browser.addOpenWindowListener(event -> {
			System.out.println("Open Window Listener");
			event.browser = browserChild;
		});
		browserChild.addVisibilityWindowListener(VisibilityWindowListener.showAdapter(event -> {
			System.out.println("Open shell");
			childShell.open();
			browserChild.setText("Child Browser");
		}));
		shell.open();
		browser.setText("""
				<html>
					<script type='text/javascript'>
						var newWin = window.open('about:blank');
					</script>
					<body>
						This test uses javascript to open a new window.
					</body>
				</html>
				""");
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
	}
}

Expected result

A child window should be opened

Actual result

No child window is opened

Reverting back to a working version of WebKit

Version 2.44 of WebKit didn't have this problem. You can revert back to that version by running this command:

VERSION=2.44.0-2 && sudo apt-get install libwebkit2gtk-4.1-0=${VERSION} libjavascriptcoregtk-4.1-0=${VERSION}

Original issue: failing tests

These 3 tests fail on Linux. I noticed in this run of #1496 and I was also able to reproduce it locally using WSL2:

org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_OpenWindowListener_open_ChildPopup()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_OpenWindow_Progress_Listener_ValidateEventOrder()
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_VisibilityWindowListener_eventSize()

It seems to be some issue with JavaScript (just my guess), here are some screenshots (WSL2):

All 3 tests timed out.

The text was updated successfully, but these errors were encountered:

jukzi · 2024-10-30T14:54:17Z

"More" is a comparison. Did you mean "Multiple" which is a numeric? Is the failure always reproduceable or random?

fedejeanne · 2024-10-30T16:20:56Z

"More" is a comparison. Did you mean "Multiple" which is a numeric? Is the failure always reproduceable or random?

I originally meant "more" because I wanted to mention the other tests that are failing (for which there is already an issue) but I changed my mind to avoid confusion. I changed the title now, thank you for the pointer.

The tests fail very consistently when I run them locally. I am not sure about the failures in the pipelines though, I've only seen them failing in my own PRs.

HeikoKlare · 2024-11-07T08:22:59Z

I can reproduce the failures locally on Ubuntu 24.04.1, Webkit 2.46.1. Tests fail with both X11 and Wayland.
When debugging the code, I found that the JavaScript used to open a child window is not even executed. JavaScript is properly enabled for the browser.

When I use the WebKit browser inside Eclipse and navigate to an HTML file that contains the same code as passed to the browser in the test, a child window pops up as expected.
So may the problem be related to some (new) restriction regarding what WebKitGTK#webkit_web_view_load_html() (called by Browser#setText()) is allowed to do?

HannesWell · 2024-11-08T06:56:18Z

In tonight's I-build these tests now fail for all java versions 17,21 and 23. In the last night's it only failed for 17:
https://download.eclipse.org/eclipse/downloads/drops4/I20241107-1800/testResults.php

I cannot tell if this is related to switching to Ubunut based images for Linux (eclipse-platform/eclipse.platform.releng.aggregator#2522) or if this is all just coincidence.

akurtakov · 2024-11-08T07:00:17Z

In tonight's I-build these tests now fail for all java versions 17,21 and 23. In the last night's it only failed for 17: https://download.eclipse.org/eclipse/downloads/drops4/I20241107-1800/testResults.php

I cannot tell if this is related to switching to Ubunut based images for Linux (eclipse-platform/eclipse.platform.releng.aggregator#2522) or if this is all just coincidence.

I believe it's related (e.g. different webkitgtk version) but failing constantly is better than randomly.

HeikoKlare · 2024-11-16T07:53:32Z

I can now confirm that an update of webkit introduced these test failures. I just downgraded from version 2.46.1 to 2.44.0 and the tests run fine again. More precisely, I downgraded the following libraries on an Ubuntu 24.04 system (target version: 2.44.0-2, original version: 2.46.1-0ubuntu0.24.04.1):

libwebkit2gtk-4.1.0
libjavascriptcoregtk-4.1.0
libwebkitgtk-6.0.4
libjavascriptcoregtk-6.0.1

akurtakov · 2024-11-16T08:02:09Z

I can't notice anything in webkitgtk news file but it doesn't seem to contain changes in webkit engine itself but only changes to the "bindings" aka it's still to be figured where to find the changes in the engine itself.

HeikoKlare · 2024-11-16T08:40:26Z

Indeed. I have not yet understood where the event flow stops. It does not seem to be missing JavaScript execution (as I indicated first), but rather with subsequent event processing. I also found a warning being logged with the current WebKit version that may direct to the problem (the "child" browser not being instantiated correctly):

** (SWT:32751): WARNING **: 09:27:41.245: WebKitWebView returned by WebKitWebView::create signal was not created with the related WebKitWebView

I have extracted one of the test cases into a standalone snippet (but the essence of the snippet is the same for all failing tests, so the root cause should be the same):

public class OpenChildBrowser {
	public static void main(String[] args) {
		Display display = new Display();
		final Shell shell = new Shell(display);
		shell.setLayout(new FillLayout());
		final Browser browser = new Browser(shell, SWT.NONE);
		Shell childShell = new Shell(shell, SWT.None);
		childShell.setText("Child shell");
		childShell.setLayout(new FillLayout());
		final Browser browserChild = new Browser(childShell, SWT.NONE);
		browser.addOpenWindowListener(event -> {
			System.out.println("Open Window Listener");
			event.browser = browserChild;
		});
		browserChild.addVisibilityWindowListener(VisibilityWindowListener.showAdapter(event -> {
			System.out.println("Open shell");
			childShell.open();
			browserChild.setText("Child Browser");
		}));
		shell.open();
		browser.setText("""
				<html>
					<script type='text/javascript'>
						var newWin = window.open('about:blank');
					</script>
					<body>
						This test uses javascript to open a new window.
					</body>
				</html>
				""");
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch())
				display.sleep();
		}
		display.dispose();
	}
}

The flow stops between processing the window opening event of the "main" browser (setting the event.browser to a child browser) and the listener on the child browser.
Note: Similar implementations may be used in productive code and not only in tests, so this may present as an actual regression for consumers and not only as test failures. I do not see that there is something wrong/illegal in the test code. That's why I also changed the issue title to cover that this is not "only" a test issue. Feel free to improve the title with something more fitting/expressive.

This is the log output of above snippet for WebKit 2.44.0 (the second line is an added println to WebKit#webkit_web_view_ready()):

open window listener
webview ready
open shell

This is the log output of above snippet for WebKit 2.46.1:

open window listener

** (SWT:32751): WARNING **: 09:27:41.245: WebKitWebView returned by WebKitWebView::create signal was not created with the related WebKitWebView

Unfortunately, I can currently not put more effort into this. Whoever wants to take over may find these commands useful (if on Ubuntu 24.04) to switch between the two WebKit versions for testing purposes:

Switch to current WebKit (2.46.1):

apt-get install libwebkitgtk-6.0.4=2.46.1-0ubuntu0.24.04.1 libjavascriptcoregtk-6.0.1=2.46.1-0ubuntu0.24.04.1

Switch to previous WebKit (2.44.0):

apt-get install libwebkitgtk-6.0.4=2.44.0-2 libjavascriptcoregtk-6.0.1=2.44.0-2 libwebkit2gtk-4.1.0=2.44.0-2 libjavascriptcoregtk-4.1.0=2.44.0-2

fedejeanne · 2024-11-19T08:50:26Z

I was also looking at this and debugging side to side WebKit 2.32.4 (Ubuntu 18.04.5 LTS) vs WebKit 2.46.1 (Ubuntu 24.04 LTS). All I can tell is that for 2.46.1 some WindowEvent never reaches the queue Synchronizer::messages and therefore the VisibilityWindowListener created in this snippet will never be called. This WindowEvent is supposed to be created right after the OpenWindowListener from the snippet is executed but that is exactly where the error pops up:

** (SWT:32751): WARNING **: 09:27:41.245: WebKitWebView returned by WebKitWebView::create signal was not created with the related WebKitWebView

Looking at the documentation of create, webkit_web_view_new_with_related_view and WebKitProcessModel and judging by the fact that set_process_model has been deprecated in version 2.40 my best guess is that something changed in the default values and now one has to somehow bond the parent webview and the child webview together, as it is mentioned in the documentation of create...

When using WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES process model, the new WebKitWebView should be related to web_view to share the same web process, see webkit_web_view_new_with_related_view() for more details.

... which wasn't necessary before. But then again, this is just a guess and it relies on the fact that the default value of the WebKitProcessModel was WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS.

If someone knows how to check if older versions of webkit were in fact using WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS while the newer version uses WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES then please share this info here.

That's as far as I could get. Hopefully someone with more knowledge can help understand and solve this issue.

akurtakov · 2024-11-21T08:46:33Z

I have tried using WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS (via calling webkit_web_context_set_process_model) on webkitgtk 2.46.3 but it failed(no change in behavior) with :

** (SWT:1131600): WARNING **: 10:43:14.640: WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS is deprecated and has no effect

fedejeanne · 2024-11-21T12:49:06Z

Thank you for testing it!

Would it be possible for you to bind the method get_process_model and provide the output for the old and the new version of WebKit?

If not, any hint on how to bind the method myself would be appreciated. If I can bind it and call it, I can provide the output myself, but binding is sadly still beyond my ken 😅

akurtakov · 2024-11-21T13:03:29Z

@fedejeanne akurtakov@e5e9387 (edited to point to fixed commit) and LOCAL REBUILD OF NATIVES is all you need. As per https://webkitgtk.org/reference/webkit2gtk/stable/enum.ProcessModel.html - printing 0 is shared, 1 is multiple processes. On my webkitgtk 2.46.3 I get "Process Model:1".

fedejeanne · 2024-11-21T16:21:39Z

@akurtakov thank you for the help, I got it to run and I called get_process_model.

I tried with the following versions of WebKit:

2.36.0
2.44.0
2.46.3

All of them in Ubuntu 24.04.

This is what I found out:

All versions of WebKit print Process Model: 1 (multiple processes)
If I use your commit as it is then no version of WebKit will open the child window
If I revert the changes you introduced in lines 2171-2172 of WebKit::webkit_create_web_view then at least the older versions of WebKit work as expected i.e. the child browser is shown

The last 2 points show that using

if (browser != null && !browser.isDisposed ()) {
	webView = WebKitGTK.webkit_web_view_new_with_related_view( ((WebKit)browser.webBrowser).webView);
	return webView;
}

... instead of

if (browser != null && !browser.isDisposed ()) {
	return ((WebKit)browser.webBrowser).webView;
}

... does not work, it actually breaks the older implementations too.

But maybe you could try something in the same direction and see if we can successfully bind the child and the parent browser?

akurtakov · 2024-11-21T16:48:52Z

Oops, the part that broke for you is a local experiment (totally unsuccessful for now) that was not supposed to end up in this commit.

fedejeanne · 2024-11-22T07:50:53Z

Oops, the part that broke for you is a local experiment (totally unsuccessful for now) that was not supposed to end up in this commit.

No worries, it was easy to spot it and I appreciate the experimentation you're doing :-)

jukzi · 2024-11-26T08:17:09Z

in https://download.eclipse.org/eclipse/downloads/drops4/I20241125-1220/testresults/html/org.eclipse.swt.tests_ep435I-unit-linux-x86_64-java21_linux.gtk.x86_64_21.html
there are even 4 tests failing. Added:

java.lang.IllegalStateException: Timer already cancelled.
at java.base/java.util.Timer.sched(Timer.java:409)
at java.base/java.util.Timer.schedule(Timer.java:205)
at org.eclipse.test.TracingSuite$TracingRunNotifier.fireTestStarted(TracingSuite.java:142)
at org.eclipse.test.TracingSuite.runChild(TracingSuite.java:287)

fedejeanne added junit JUnit test failure Linux/GTK Happens on Linux labels Oct 30, 2024

fedejeanne changed the title ~~More tests failing in Test_org_eclipse_swt_browser_Browser~~ Multiple tests failing in Test_org_eclipse_swt_browser_Browser Oct 30, 2024

HeikoKlare mentioned this issue Nov 7, 2024

Expand Bar is not scaled during DPI change #1528

Merged

1 task

This was referenced Nov 7, 2024

[I-Build-Tests] Run Linux tests on 'ubuntu-2404' image agent eclipse-platform/eclipse.platform.releng.aggregator#2522

Merged

[win32] Fix for refreshing the background image #1576

Merged

fedejeanne self-assigned this Nov 13, 2024

HeikoKlare mentioned this issue Nov 13, 2024

Store Edge instance in Environemnt record sync-ly #1595

Merged

elsazac mentioned this issue Nov 15, 2024

Declare 4.34 RC1 eclipse-platform/eclipse.platform.releng.aggregator#2540

Closed

13 tasks

fedejeanne removed the junit JUnit test failure label Nov 18, 2024

elsazac mentioned this issue Nov 22, 2024

Declare 4.34 RC2 eclipse-platform/eclipse.platform.releng.aggregator#2553

Closed

13 tasks

akurtakov mentioned this issue Nov 22, 2024

Browser tests are failing #1613

Closed

jukzi added the junit JUnit test failure label Nov 26, 2024

fedejeanne removed their assignment Nov 26, 2024

fedejeanne added bug Something isn't working regression Something that used to work Webkit labels Nov 26, 2024

This was referenced Nov 27, 2024

[GTK3] Do not crash in SetData event #1612

Draft

[GTK3] Test Tree crash in SetData event #1611

Open

This was referenced Dec 3, 2024

#924 [Win32] Possible ERROR_GRAPHIC_DISPOSED error during painting #1441

Merged

[win32] No handle creation on Image::getBounds #1643

Merged

fedejeanne mentioned this issue Dec 11, 2024

Use Edge/WebView2 as the default browser on Windows #1466 #1637

Merged

jukzi mentioned this issue Dec 12, 2024

PatternWin32ManualTest: suppress Discouraged access warning #1620

Merged

jukzi added the help wanted Extra attention is needed label Dec 12, 2024

jukzi changed the title ~~Multiple tests failing in Test_org_eclipse_swt_browser_Browser~~ 3 tests failing in Test_org_eclipse_swt_browser_Browser Dec 12, 2024

akurtakov mentioned this issue Dec 13, 2024

Convert Browser test strings to test blocks #1658

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3 tests failing in Test_org_eclipse_swt_browser_Browser #1564

3 tests failing in Test_org_eclipse_swt_browser_Browser #1564

fedejeanne commented Oct 30, 2024 •

edited

Loading

jukzi commented Oct 30, 2024

fedejeanne commented Oct 30, 2024

HeikoKlare commented Nov 7, 2024

HannesWell commented Nov 8, 2024

akurtakov commented Nov 8, 2024

HeikoKlare commented Nov 16, 2024

akurtakov commented Nov 16, 2024

HeikoKlare commented Nov 16, 2024 •

edited by fedejeanne

Loading

fedejeanne commented Nov 19, 2024 •

edited

Loading

akurtakov commented Nov 21, 2024 •

edited

Loading

fedejeanne commented Nov 21, 2024

akurtakov commented Nov 21, 2024 •

edited

Loading

fedejeanne commented Nov 21, 2024 •

edited

Loading

akurtakov commented Nov 21, 2024

fedejeanne commented Nov 22, 2024

jukzi commented Nov 26, 2024

3 tests failing in Test_org_eclipse_swt_browser_Browser #1564

3 tests failing in Test_org_eclipse_swt_browser_Browser #1564

Comments

fedejeanne commented Oct 30, 2024 • edited Loading

The problem

How to reproduce

Expected result

Actual result

Reverting back to a working version of WebKit

Original issue: failing tests

jukzi commented Oct 30, 2024

fedejeanne commented Oct 30, 2024

HeikoKlare commented Nov 7, 2024

HannesWell commented Nov 8, 2024

akurtakov commented Nov 8, 2024

HeikoKlare commented Nov 16, 2024

akurtakov commented Nov 16, 2024

HeikoKlare commented Nov 16, 2024 • edited by fedejeanne Loading

fedejeanne commented Nov 19, 2024 • edited Loading

akurtakov commented Nov 21, 2024 • edited Loading

fedejeanne commented Nov 21, 2024

akurtakov commented Nov 21, 2024 • edited Loading

fedejeanne commented Nov 21, 2024 • edited Loading

akurtakov commented Nov 21, 2024

fedejeanne commented Nov 22, 2024

jukzi commented Nov 26, 2024

fedejeanne commented Oct 30, 2024 •

edited

Loading

HeikoKlare commented Nov 16, 2024 •

edited by fedejeanne

Loading

fedejeanne commented Nov 19, 2024 •

edited

Loading

akurtakov commented Nov 21, 2024 •

edited

Loading

akurtakov commented Nov 21, 2024 •

edited

Loading

fedejeanne commented Nov 21, 2024 •

edited

Loading