Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code according to Eclipse standards #1600

Open
tmssngr opened this issue Nov 19, 2024 · 0 comments
Open

Reformat code according to Eclipse standards #1600

tmssngr opened this issue Nov 19, 2024 · 0 comments

Comments

@tmssngr
Copy link
Contributor

tmssngr commented Nov 19, 2024

For example, in Path:

  • some methods/constructors have a space before the parameter list, others not,
  • between some related methods is an empty line, but not so for others

For example, GC:

  • some method invocations have a space before the (, others not

  • some arguments are final, others not

  • why are fields indented, but methods not

  • is it desired to make fields private if possible (otherwise reading the code indicates to me that they might be set to null somewhere)?

  • is it desired to make methods private if possible (otherwise reading the code indicates to me that they might be invoked from outside)?

  • is it desired to use collections? If yes, rather the interface or the implementation (the above Path is using a field of type HashMap - I'd recommend Map instead)?

PS: Where I can find the standard layout documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant