Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails intermittently, both on IE and on Edge #1656

Open
fedejeanne opened this issue Dec 12, 2024 · 4 comments
Labels
edge Edge Browser junit JUnit test failure regression Something that used to work Windows Happens on Windows OS

Comments

@fedejeanne
Copy link
Contributor

fedejeanne commented Dec 12, 2024

The test fails locally and it can fail with both browsers on Windows.

I ran the test using the parameterized version of the test class org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser that can be found in #672 (I disabled all other tests in the class to speed up the testing), I swapped the parameters around and also enabled/disabled them, just for fun, and this is what I saw:

image

image

image

image

image

Note: [browser flags: 0] means Edge and [browser flags: 524,288] means IE

The only combination that I couldn't get was: First Edge then IE and both failing... but I can't say that one won't fail either.

@fedejeanne fedejeanne added junit JUnit test failure Windows Happens on Windows OS edge Edge Browser labels Dec 12, 2024
@HeikoKlare
Copy link
Contributor

HeikoKlare commented Dec 12, 2024

Browser tests are still executed with IE, not with Edge, see:

So the failure occurs with IE. This can also be seen in the used flag browser flags: 524,288. This is the one for IE.
The test has just been introduced via:

@sratz sratz changed the title org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails on Edge org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails on IE Dec 12, 2024
@jukzi jukzi added the regression Something that used to work label Dec 13, 2024
@fedejeanne fedejeanne changed the title org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails on IE org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails on IE and on Edge Dec 13, 2024
@fedejeanne fedejeanne changed the title org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails on IE and on Edge org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser.test_TabTraversalOutOfBrowser fails intermittently, both on IE and on Edge Dec 13, 2024
@fedejeanne
Copy link
Contributor Author

@jukzi just for the record, this is a regression in a test and not in productive code. In productive code I tested the snippet provided in #1640 (comment) and it worked, both for IE and for Edge.

@jukzi
Copy link
Contributor

jukzi commented Dec 13, 2024

Thanks for clarification. I also put labels regression+test on tests that started to fail.

@sratz
Copy link
Member

sratz commented Dec 13, 2024

I think the Display.getDefault().post(event) is really fragile.

I don't think there is any other way to simulate an event that is supposed to originate from within the browser.

Maybe we'd need to remove the test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edge Edge Browser junit JUnit test failure regression Something that used to work Windows Happens on Windows OS
Projects
None yet
Development

No branches or pull requests

4 participants