Edge: Strange error when disposing a new Browser instance immediately after creating it

[merks]

When using the latest target platform, starting the installer logs exceptions like this:

!MESSAGE No more handles [0x8007139f]
!STACK 0
org.eclipse.swt.SWTError: No more handles [0x8007139f]
	at org.eclipse.swt.SWT.error(SWT.java:4962)
	at org.eclipse.swt.browser.Edge.error(Edge.java:225)
	at org.eclipse.swt.browser.Edge.setupBrowser(Edge.java:600)
	at org.eclipse.swt.browser.Edge.lambda$10(Edge.java:580)
	at org.eclipse.swt.browser.Edge.lambda$5(Edge.java:232)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(Native Method)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3693)
	at org.eclipse.oomph.setup.internal.installer.Installer.runEventLoop(Installer.java:382)
	at org.eclipse.oomph.setup.internal.installer.SimpleInstallerDialog.runEventLoop(SimpleInstallerDialog.java:1001)
	at org.eclipse.oomph.setup.internal.installer.AbstractSimpleDialog.show(AbstractSimpleDialog.java:195)
	at org.eclipse.oomph.setup.internal.installer.InstallerApplication.run(InstallerApplication.java:295)
	at org.eclipse.oomph.setup.internal.installer.InstallerApplication.start(InstallerApplication.java:401)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:143)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:109)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:439)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:271)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:668)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:605)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1481)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1454)

I was messing around with the code that tests whether a browser can be created:

  public static synchronized boolean isBrowserAvailable()
  {
    if (browserAvailable == null)
    {
      syncExec(new Runnable()
      {
        @Override
        public void run()
        {
          Shell shell = null;

          try
          {
            shell = new Shell();
            new Browser(shell, SWT.NONE);
            while (shell.getDisplay().readAndDispatch())
            {
            }
            browserAvailable = true;
          }
          catch (SWTError ex)
          {
            browserAvailable = false;
          }
          finally
          {
            try
            {
              shell.dispose();
            }
            catch (Exception ex)
            {
              // Ignore.
            }
          }
        }
      });
    }

    return browserAvailable;
  }

Adding the while (shell.getDisplay().readAndDispatch()) makes the problem go away, so I think if one creates a browser and disposes it, there are maybe still events processed later for that browser that fail in this strange way. Does anything guard that you aren't trying to process something for a disposed Edge instance?

[merks]

I'm also seeing this in my console with the installer and when launching an IDE upon termination.

[1216/090005.320:ERROR:window_impl.cc(121)] Failed to unregister class Chrome_WidgetWin_0. Error = 1411

[Phillipus]

[1216/090005.320:ERROR:window_impl.cc(121)] Failed to unregister class Chrome_WidgetWin_0. Error = 1411

I've seen that for a long time using Edge in our RCP app. If you do a web search on that message you'll find that it's been around for a long time.

And see #1498

[sratz]

The error handling in

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

Lines 586 to 601 in 1ced8a9

	void setupBrowser(int hr, long pv) {
	if(browser.isDisposed()) {
	browserDispose(new Event());
	return;
	}
	switch (hr) {
	case COM.S_OK:
	break;
	case COM.E_WRONG_THREAD:
	containingEnvironment.instances().remove(this);
	error(SWT.ERROR_THREAD_INVALID_ACCESS, hr);
	break;
	default:
	containingEnvironment.instances().remove(this);
	error(SWT.ERROR_NO_HANDLES, hr);
	}

might not be sufficient.

In this case I think we are seeing 'The creation will fail with E_ABORT if parentWindow is destroyed before the creation is finished.' according to https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2environment#createcorewebview2controller.

Defaulting to NO_MORE_HANDLES as error code does not seem ideal to me in general.

[fedejeanne]

cc @amartya4256 , @akoch-yatta

[merks]

FYI, this workaround works okay:

  public static synchronized boolean isBrowserAvailable()
  {
    if (browserAvailable == null)
    {
      syncExec(new Runnable()
      {
        @Override
        public void run()
        {
          try
          {
            Shell shell = new Shell();
            shell.getDisplay().asyncExec(() -> {
              try
              {
                shell.dispose();
              }
              catch (Exception ex)
              {
                // Ignore.
              }
            });

            new Browser(shell, SWT.NONE);
            browserAvailable = true;
          }
          catch (SWTError ex)
          {
            browserAvailable = false;
          }
        }
      });
    }

    return browserAvailable;
  }

The workaround above broke other logic that relied on posting events for delays processing...

[fedejeanne]

This error shows up also in the builds in master (GH Actions) e.g. right after merging #1673

I added it to our board: vi-eclipse/Eclipse-Platform#163

[HeikoKlare]

In this case I think we are seeing 'The creation will fail with E_ABORT if parentWindow is destroyed before the creation is finished.' according to https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2environment#createcorewebview2controller.

I agree that we need to implement that case. I actually have a branch lying around to implement this but forgot to propose a PR from it so far. I will do that today.

Still, that does not seem to be the issue that we face here. The error code for an aborted operation is 0x80004004.
The error code we have here is 0x8007139f, which means: The group or resource is not in the correct state to perform the requested operation.
According to a quick web search, this may arise when there is still a WebView process running for the same data folder for which you try to create a new WebView environment.