For this to work we need a full Clipboard get contents implementation on GTK4. At the moment, only gdk_clipboard_get_content is used to get data from the clipboard, but gdk_clipboard_get_content is only for getting content from the clips in the current process. Depending on the clipboard manager that is running, the contents of even stuff copied from our process may be transferred off our process leading to a null value when calling Clipboard.getContents.

The correct method to use is gdk_clipboard_read_value_async() (and perhaps the provided wrappers) which asynchronously obtains the requested data - this is roughly equivalent to how GTK3 did it in gtk_clipboard_wait_for_contents which is done here

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT Drag and Drop/gtk/org/eclipse/swt/dnd/Clipboard.java

Lines 710 to 726 in de23a39

    
           long gtk_clipboard_wait_for_contents(long clipboard, long target) { 
        
           	long startTime = System.currentTimeMillis(); 
        
           	String key = "org.eclipse.swt.internal.gtk.dispatchEvent"; 
        
           	Display display = this.display; 
        
           	display.setData(key, new int[]{GDK.GDK_PROPERTY_NOTIFY, GDK.GDK_SELECTION_CLEAR, GDK.GDK_SELECTION_REQUEST, GDK.GDK_SELECTION_NOTIFY}); 
        
           	long selection_data = GTK3.gtk_clipboard_wait_for_contents(clipboard, target); 
        
           	display.setData(key, null); 
        
           	long duration = System.currentTimeMillis() - startTime; 
        
           	if (selection_data == 0 && duration > 5000) { 
        
           		// Bug 241957: In case of timeout take clipboard ownership to unblock future calls 
        
           		ClipboardProxy._getInstance(display).setData(this, new String[] {" "}, 
        
           				new Transfer[] { TextTransfer.getInstance() }, 
        
           				clipboard == GTKCLIPBOARD ? DND.CLIPBOARD : DND.SELECTION_CLIPBOARD); 
        
           	} 
        
           	return selection_data; 
        
           } 
        
           }

	long gtk_clipboard_wait_for_contents(long clipboard, long target) {
	long startTime = System.currentTimeMillis();
	String key = "org.eclipse.swt.internal.gtk.dispatchEvent";
	Display display = this.display;
	display.setData(key, new int[]{GDK.GDK_PROPERTY_NOTIFY, GDK.GDK_SELECTION_CLEAR, GDK.GDK_SELECTION_REQUEST, GDK.GDK_SELECTION_NOTIFY});
	long selection_data = GTK3.gtk_clipboard_wait_for_contents(clipboard, target);
	display.setData(key, null);
	long duration = System.currentTimeMillis() - startTime;
	if (selection_data == 0 && duration > 5000) {
	// Bug 241957: In case of timeout take clipboard ownership to unblock future calls
	ClipboardProxy._getInstance(display).setData(this, new String[] {" "},
	new Transfer[] { TextTransfer.getInstance() },
	clipboard == GTKCLIPBOARD ? DND.CLIPBOARD : DND.SELECTION_CLIPBOARD);
	}
	return selection_data;
	}
	}

[GTK4] StyledText paste doesn't do anything #2126

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions