Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] GC#fillGradientRectangle don't color for y < 0 #1652 #1655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

csa-smt
Copy link

@csa-smt csa-smt commented Dec 12, 2024

GC#fillGradientRectangle must be applied for negative y too.

Fixes #1652

…#1652

GC#fillGradientRectangle must be applied for negative y too.

Fixes eclipse-platform#1652
@csa-smt
Copy link
Author

csa-smt commented Dec 12, 2024

I have already signed the Eclipse Contributor Agreement (ECA) with my personal email in the past.
My GitHub account has been created with my company email.
Il have followed https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md by adding my personal email to my GitHub account, but the check of the ECA has failed.

Should I make my email addresses public in my GitHub account?
Or should I define my personal email as the primary email address of my GitHub account ?

@Phillipus
Copy link
Contributor

This bug was introduced by commit 4f5f2dc

This PR reverses that commit. Does it cause a regression for that fix?

@csa-smt
Copy link
Author

csa-smt commented Dec 13, 2024

This PR reverses that commit. Does it cause a regression for that fix?

See #1652 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mac] GC#fillGradientRectangle don't color for y < 0
2 participants