Additional Separator #549

This PR provides additional separation and arrangements between Enable/Disable Actions in breakpoints view. New actions can be contributed here. Part of Enhancement #eclipse-jdt/eclipse.jdt.debug#550
eclipse-platform · Nov 29, 2024 · a892dfe · a892dfe
1 parent 3776c2f
commit a892dfe
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/debug/org.eclipse.debug.ui/plugin.xml b/debug/org.eclipse.debug.ui/plugin.xml
@@ -1505,38 +1505,38 @@
                definitionId="org.eclipse.ui.edit.copy"
                helpContextId="copy_breakpoints_action_context"
                class="org.eclipse.debug.internal.ui.actions.breakpointGroups.CopyBreakpointsActionDelegate"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                id="org.eclipse.debug.ui.breakpointsView.toolbar.copy"/>
          <action
                label="%SelectAll.label"
                helpContextId="select_all_breakpoints_action_context"
                definitionId="org.eclipse.ui.edit.selectAll"
                class="org.eclipse.debug.internal.ui.actions.breakpoints.SelectAllBreakpointsAction"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                id="org.eclipse.debug.ui.actions.SelectAllBreakpointsAction">
          </action>
          <action
                label="%RemoveAllAction.label"
                icon="$nl$/icons/full/elcl16/rem_all_co.png"
                helpContextId="remove_all_breakpoints_action_context"
                class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveAllBreakpointsAction"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                id="org.eclipse.debug.ui.actions.RemoveAllBreakpoints">
          </action>
          <action
                label="%RemoveAllTriggerpoints.label"
                icon="$nl$/icons/full/elcl16/rem_all_triggers.png"
                helpContextId="remove_all_breakpoints_action_context"
                class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveAllTriggerPointsAction"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                id="org.eclipse.debug.ui.actions.RemoveAllTriggerpoints">
          </action>
         <action
                label="%RemoveAction.label"
                icon="$nl$/icons/full/elcl16/rem_co.png"
                helpContextId="remove_breakpoint_action_context"
                class="org.eclipse.debug.internal.ui.actions.breakpoints.RemoveBreakpointAction"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                enablesFor="+"
                id="org.eclipse.debug.ui.breakpointsView.toolbar.remove">
         </action>
@@ -1545,7 +1545,7 @@
                icon="$nl$/icons/full/elcl16/disabled_co.png"
                helpContextId="disable_breakpoint_action_context"
                class="org.eclipse.debug.internal.ui.actions.breakpoints.DisableAllBreakpointsAction"
-               menubarPath="breakpointGroup"
+               menubarPath="BreakpointAdditionalGroup"
                id="org.eclipse.debug.ui.actions.DisableAllBreakpoint">
         </action>
         <action

diff --git a/....eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java b/....eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/breakpoints/BreakpointsView.java
@@ -196,6 +196,9 @@ protected void fillContextMenu(IMenuManager menu) {
 		menu.add(getAction(ACTION_GOTO_MARKER));
 		menu.add(new Separator(IDebugUIConstants.EMPTY_BREAKPOINT_GROUP));
 		menu.add(new Separator(IDebugUIConstants.BREAKPOINT_GROUP));
+		Separator separator = new Separator(IDebugUIConstants.BREAKPOINT_ADDITIONAL_GROUP);
+		separator.setVisible(false);
+		menu.add(separator);
 		IAction action = getAction(PASTE_ACTION);
 		if (action != null) {
 			menu.add(action);

diff --git a/debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/IDebugUIConstants.java b/debug/org.eclipse.debug.ui/ui/org/eclipse/debug/ui/IDebugUIConstants.java
@@ -774,6 +774,14 @@ public interface IDebugUIConstants {
 	 */
 	String BREAKPOINT_GROUP = "breakpointGroup"; //$NON-NLS-1$
 
+	/**
+	 * Identifier for breakpoint operations other than enable/disable succeeding a
+	 * breakpoint group in a menu (value <code>"BreakpointAdditionalGroup"</code>).
+	 *
+	 * @since 3.18
+	 */
+	String BREAKPOINT_ADDITIONAL_GROUP = "BreakpointAdditionalGroup"; //$NON-NLS-1$
+
 	/**
 	 * Identifier for a "breakpoint group" group in a menu (value <code>"breakpointGroupGroup"</code>).
 	 *