SHACL validation not considering datatypes

[MajewskiKrzysztof]

I've noticed an invalid behavior when running SHACL validation for JSON-LD input.
This is my code:

String SHAPES = "C:\\Users\\MAJEWSK6\\Desktop\\SHACL_TEST\\rulesJsonLd.jsonld";
String DATA = "C:\\Users\\MAJEWSK6\\Desktop\\SHACL_TEST\\inputJsonLd.jsonld";
​
ShaclSail shaclSail = new ShaclSail(new MemoryStore());
Repository repo = new SailRepository(shaclSail);
​
try (RepositoryConnection connection = repo.getConnection()) {
    connection.begin();
    connection.add(new StringReader(Files.readString(Path.of(SHAPES))), RDFFormat.JSONLD, RDF4J.SHACL_SHAPE_GRAPH);
    connection.commit();
​
    connection.begin();
    connection.add(new StringReader(Files.readString(Path.of(DATA))), RDFFormat.JSONLD);
    connection.commit();
​
    connection.begin();
    connection.clear(RDF4J.SHACL_SHAPE_GRAPH);
    connection.commit();
} catch (Exception e) {
    Throwable cause = e.getCause();
    if (cause instanceof ValidationException) {
        Model validationReportModel = ((ValidationException) cause).validationReportAsModel();
        Rio.write(validationReportModel, System.out, RDFFormat.TURTLE);
    }
}

The payload file:

{
    "@context": {
        "Class": "http://example.com/Class",
        "property": {
            "@id": "http://example.com/Property",
            "@type": "http://www.w3.org/2001/XMLSchema#integer"
        }
    },
    "@graph": {
        "@type": "Class",
        "@id": "http://example.com/1",
        "property": "test"
    }
}

And the rules file:

{
  "@context": {
    "@base": "http://ontology.roche.com/",
    "@vocab": "http://ontology.roche.com/model/rts/core/",
    "id": "@id",
    "type": "@type",
    "datatype": {
      "@id": "http://www.w3.org/ns/shacl#datatype",
      "@type": "@id"
    },
    "path": {
      "@id": "http://www.w3.org/ns/shacl#path",
      "@type": "@id"
    },
    "class": {
      "@id": "http://www.w3.org/ns/shacl#class",
      "@type": "@id"
    },
    "describes": {
      "@type": "@id"
    },
    "property": {
      "@id": "http://www.w3.org/ns/shacl#property",
      "@type": "@id",
      "@container": "@set"
    },
    "targetClass": {
      "@id": "http://www.w3.org/ns/shacl#targetClass",
      "@type": "@id"
    },
    "maxCount": "http://www.w3.org/ns/shacl#maxCount",
    "minCount": "http://www.w3.org/ns/shacl#minCount",
    "PropertyShape": "http://www.w3.org/ns/shacl#PropertyShape",
    "Property": "http://www.w3.org/1999/02/22-rdf-syntax-ns#Property",
    "NodeShape": "http://www.w3.org/ns/shacl#NodeShape",
    "Class": "http://www.w3.org/2002/07/owl#Class",
    "DatatypeProperty": "http://www.w3.org/2002/07/owl#DatatypeProperty"
  },
  "@graph": [
    {
      "id": "http://example.com/Property",
      "type": [
        "DatatypeProperty",
        "Property"
      ]
    },
    {
      "id": "http://example.com/Class",
      "type": "Class"
    },
    {
      "id": "http://example.com/ClassShape",
      "type": "NodeShape",
      "property": [
        "http://example.com/PropertyShape"
      ],
      "targetClass": "http://example.com/Class"
    },
    {
      "id": "http://example.com/PropertyShape",
      "type": "PropertyShape",
      "datatype": "http://www.w3.org/2001/XMLSchema#integer",
      "maxCount": 1,
      "minCount": 1,
      "path": "http://example.com/Property"
    }
  ]
}

​
After running this example I get no violations.
Shouldn't the "test" cause shacl:DatatypeConstraintComponent when passed as integer?
​
The same issue exists for other datatypes like xsd:dateTime for example. It accepts any string value.

[hmottestad]

When I convert your data to NQUADS it looks like this:

<http://example.com/1> <http://example.com/Property> "test"^^<http://www.w3.org/2001/XMLSchema#integer> .
<http://example.com/1> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://example.com/Class> .

It looks like you are expecting the SHACL validation to check that the value conforms to the restrictions of the datatype. My understanding of the SHACL specification is that we should rely on the specified datatype and not perform any other checks if the datatype matches the constraint.

RDF4J supports checking that the value conforms to the datatype during parsing. See https://rdf4j.org/javadoc/latest/org/eclipse/rdf4j/rio/helpers/BasicParserSettings.html#VERIFY_DATATYPE_VALUES and https://rdf4j.org/documentation/programming/rio/#configuring-the-parser--writer

[hmottestad]

I also tried switching from xsd:integer to xsd:int there doesn’t seem to any validation and the "test" string with xsd:int as datatype passes validation.

[hmottestad]

You could post to the SHACL mailing list and ask what the recommended approach is.

[afs]

https://www.w3.org/TR/shacl/#DatatypeConstraintComponent
There is an "ill-typed" condition for some XSD datatypes.

A literal matches a datatype if the literal's datatype has the same IRI and, for the datatypes supported by SPARQL 1.1, is not an ill-typed literal.

so some XSD datatypes are special.

TQ SHACL (java) generates a violation for "test"^^xsd:date (xsd:date isn't a SPARQL 1.1 datatype).
TQ SHACL gives a violation on "test"^^xsd:int.

[hmottestad]

Mischievous of you Andy to edit the spec while no one was watching. I could have sworn it didn't say anything about ill-typed literals when I was reading it. I guess that does make this a bug.

[afs]

😄 Clearly, you are watching!

I didn't write any of the spec.

Test core/property/datatype-ill-formed in the suite. It might have been added after the others - it has a different naming style.

Personally, i think it would better to also say something like "the processor should report any ill-defined literals it can identify".