Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sampling of signals in vehicle at higher frequency #2

Open
sophokles73 opened this issue Jul 28, 2023 · 3 comments
Open

Support sampling of signals in vehicle at higher frequency #2

sophokles73 opened this issue Jul 28, 2023 · 3 comments
Labels
feature request help wanted Extra attention is needed

Comments

@sophokles73
Copy link
Contributor

So far, the signals in the vehicle are being sampled at discreet points in time only, triggered by arbitrary events like a timer firing (e.g. every 5s) or the engine being started etc.
This seems to be in line with the requirements of the rFMS spec but also means that the data points being transferred to the back end are quite sparsely distributed over time and do not allow for more than very basic analysis.

On the other hand, continuously sampling the signals at a high frequency, say 10 Hz, could potentially lead to a lot of (duplicate) data being transferred to the back end. A reasonable compromise might be to apply the curve algorithm to sampled data as suggested by GEOTAB.

There also is an example implementation in Python available on GitHub which could potentially be ported to Rust and employed in the FMS Forwarder.

@sophokles73 sophokles73 changed the title Support of signals in vehicle at higher frequency Support sampling of signals in vehicle at higher frequency Jul 28, 2023
@sophokles73 sophokles73 added feature request help wanted Extra attention is needed labels Jul 28, 2023
@tguild
Copy link

tguild commented Sep 8, 2023

@sophokles73 - Hi Kai,

I've successfully lobbied for us at Geotab to open source a Rust implementation that Sven inquired about as well as the accompanying error thresholds for the signals in the Commercial Vehicles recommendations signals list

I'm still trying to get time from the developer who wrote that version, typical resources/priority conversation but hope to streamline.

For comparison purposes and in case there is delay, it might be worth having both the current sampling guidelines and then add curve when I can line things up.

@sophokles73
Copy link
Contributor Author

Hey @tguild, that's great news :-)

@eriksven and I can help you getting started with the code base once you are set ...

@tguild
Copy link

tguild commented Dec 12, 2023

@sophokles73 and @eriksven - initial release of curve in Rust is now available.

https://github.com/Geotab/curve/tree/main/rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants