-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sprotty-elk sometimes doesn't delete old edge bends on layout changes #427
Comments
We haven't seen this in other applications using the collapse / expand feature. I think solving the issue is not possible without seeing the source code of your implementation. |
I am using elk for layouting, probably should have made that clearer. I managed to reproduce the bug in the randomgraph example from the sprotty repo by reducing the number of nodes and edges to 5 each: screencap_edges_2.mp4You can even see clearly that the problem only occurs for edges that used to have bends and now don't. Edge 0 and 4 are fine because they are always straight and egde 1 is fine because it always has bends. |
@spoenemann, I can have a look a it. |
It turned out this is an ELK bug: eclipse-elk/elk#1001 |
The video shows the issue. When expanding/collapsing nodes, edge bends are not deleted from the layout, which can turn into quite the spaghetti on larger graphs. This only happens when the edge wouldn't need bends in the new layout. If the new edge layout just needs different bend points the old bend points are being deleted as expected.
screencap_edges.mp4
The text was updated successfully, but these errors were encountered: