Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sprotty-elk sometimes doesn't delete old edge bends on layout changes #427

Closed
semira222 opened this issue Feb 10, 2024 · 4 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@semira222
Copy link

The video shows the issue. When expanding/collapsing nodes, edge bends are not deleted from the layout, which can turn into quite the spaghetti on larger graphs. This only happens when the edge wouldn't need bends in the new layout. If the new edge layout just needs different bend points the old bend points are being deleted as expected.

screencap_edges.mp4
@spoenemann
Copy link
Contributor

We haven't seen this in other applications using the collapse / expand feature. I think solving the issue is not possible without seeing the source code of your implementation.

@semira222
Copy link
Author

semira222 commented Feb 12, 2024

I am using elk for layouting, probably should have made that clearer. I managed to reproduce the bug in the randomgraph example from the sprotty repo by reducing the number of nodes and edges to 5 each:

screencap_edges_2.mp4

You can even see clearly that the problem only occurs for edges that used to have bends and now don't. Edge 0 and 4 are fine because they are always straight and egde 1 is fine because it always has bends.

@spoenemann spoenemann added the bug Something isn't working label Feb 13, 2024
@spoenemann spoenemann added this to the v1.2.0 milestone Feb 13, 2024
@jbicker
Copy link
Contributor

jbicker commented Feb 20, 2024

@spoenemann, I can have a look a it.

@spoenemann
Copy link
Contributor

It turned out this is an ELK bug: eclipse-elk/elk#1001

@spoenemann spoenemann closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants