Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppport vor DebugSession.parentSession. Fixes #11512 #11925

Merged

Conversation

tsmaeder
Copy link
Contributor

What it does

Add suppport vor DebugSession.parentSession. Fixes #11512

Adds support for the parentSession property in theia.d.ts. Includes some minor changes to make sure we're not sending theia.DebugSession object over the wire, but only session ids.

Contributed on behalf of ST Microelectronics

How to test

  1. Install the vscode extension from here: https://github.com/tsmaeder/castletest (I've attached a pre-built copy to this PR).
  2. Run Theia and open a copy of the theia source code
  3. Run the "Run Browser Backend and Frontend" launch configuration
  4. Select various debug sesssions and run the "Show active debug session" command from the command palette.
  5. Observe: you should see the name of the correct parent session printed to the output of the Theia instance under test

Review checklist

Reminder for reviewers

Adds support for the parentSession property in theia.d.ts. Includes
some minor changes to make sure we're not sending theia.DebugSession
object over the wire, but only session ids.

Contributed on behalf of ST Microelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder
Copy link
Contributor Author

castletest-0.0.1.zip

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tsmaeder tsmaeder merged commit e1f52db into eclipse-theia:master Dec 2, 2022
@vince-fugnitto vince-fugnitto added this to the 1.33.0 milestone Dec 20, 2022
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support optional property DebugSession.parentSession
3 participants