Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding | BPNL creation and check is skipped when BPN was provided in registration | DB misalignment #1212

Open
typecastcloud opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@typecastcloud
Copy link
Contributor

typecastcloud commented Dec 16, 2024

Current Behavior

While onboarding a company, the BPN Creation step is skipped (set to done) without verifying if the BPN already exists and the data is correct IF the BPN was provided by user in any way.

This can create misalignment between Portal and BPDM database!

Expected Behavior

Company data should always be verified against BPDM Pool even if using search.

Pool is source of truth! Right now a customer could enter any BPN via API and as long as the same is not yet used in portal db, the onboarding will succeed and create wallet/sd for this BPN.

Steps To Reproduce

  1. Invite company
  2. Set any existing BPNL in search for company details
  3. Save company data
  4. Submit application
  5. BPN Creation step is DONE instantly

Additional info

  • POST: application/{applicationId}/companyDetailsWithAddress
    • Endpoint allows customers to set ANY bpn they want
  • Initial checklist creation sets the BPN Creation step to DONE if BPN already exists
@typecastcloud typecastcloud added the bug Something isn't working label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Dec 16, 2024
@Phil91 Phil91 assigned Phil91 and unassigned Phil91 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: NEW USER REQUEST
Development

No branches or pull requests

2 participants