Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpClientZenoh to take in constructor enough info that we know the source / response UUri when invokeMethod() is called #15

Closed
PLeVasseur opened this issue Mar 11, 2024 · 3 comments

Comments

@PLeVasseur
Copy link
Contributor

PLeVasseur commented Mar 11, 2024

Hey @evshary 👋

I think I brought this up before, but it got lost in the shuffle.

When we create a UpClientZenoh we need to provide it the info needed such that when RpcClient::invoke_method() is called, it's able to, within the function call, build the source UUri.

Here's a few links to the up-client-android-java codebase with some pointers on how they went about it:

Could you check into this and propose a solution?

@evshary
Copy link
Contributor

evshary commented Mar 12, 2024

Okay, I think we should have a way to provide it while creating UPClientZenoh. Let me dive into the detail.

@PLeVasseur
Copy link
Contributor Author

Hey @evshary -- I kinda sorta did this over in my PR if you want to check for that as well.

@evshary
Copy link
Contributor

evshary commented Apr 17, 2024

This should be done in #24

@evshary evshary closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants