-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to record all messages and message types over all UAuthority #32
Comments
No, I don't think we can record the response from Zenoh reply currently. Maybe one workaround is just like ROS 2. The RPC Server should also publish the same message which it wants to reply. @Mallets Do you have any ideas about this? |
Would the idea be that under the hood in It's sending an extra Zenoh publish out each time a service provider sends a Response message. Is that roughly correct or is there more to it? |
Yes, that's the whole concept. |
Okay, thanks for clarifying. Let's bring this to the uProtocol Zenoh weekly to discuss a plan. 👍 |
Hey @evshary -- I think in support of the
up-zenoh-recorder
we'll need the ability to listen for all messages coming over all authorities.Seems like to me we could accomplish this with handing in an empty UUri, i.e. even the UAuthority is empty for now when calling
register_listener()
.i.e.
I think this would be able to handle the use-case of passively listening for Publish, Notification, and Request message types.
Publish & Notification
Publish and Notification are straight-forward, since they use the Zenoh Subscriber pattern.
Request
For the Request message type we would just be sure not to send a Response, so as to not "compete" with the actual service listening on that UUri.
Response
However, I'm unclear on how we would be able to passively listen to the Response message type, since in Zenoh terminology, when we handle a Request message we call reply on the query. It seems to me like there's nothing sort of "externally visible" for the uRecorder to be able to see when that happens. But maybe I'm wrong and my test case is wrong.
Test Code
I opened a draft PR over here to show the test code which is failing.
The text was updated successfully, but these errors were encountered: