Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support informing why the uri cannot be converted to a UUri #77

Open
PLeVasseur opened this issue Aug 16, 2024 · 0 comments
Open

Support informing why the uri cannot be converted to a UUri #77

PLeVasseur opened this issue Aug 16, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PLeVasseur
Copy link
Contributor

In this code snippet we drop the error that came through in the map_err.

We should probably keep it so that a user knows that went wrong and how to fix it.
@PLeVasseur PLeVasseur added enhancement New feature or request good first issue Good for newcomers labels Aug 16, 2024
sophokles73 added a commit to SoftwareDefinedVehicle/up-transport-zenoh-rust that referenced this issue Oct 8, 2024
@sophokles73
[eclipse-uprotocol#77] Do not swallow UUri conversion error
a00943e 
The functions for creating a new UPTransportZenoh have been changed
to include any error message produced when trying to create the
local UUri.
evshary pushed a commit that referenced this issue Oct 8, 2024
@sophokles73
[#78] Support passing UUri into constructors (#84)
3a97fae 
* [#78] Support passing UUri into constructors

The functions for creating a new UPTransportZenoh have been changed
to accept TryInto<UUri> which allows clients to pass in either
strings or UUri structs.

* [#77] Do not swallow UUri conversion error

The functions for creating a new UPTransportZenoh have been changed
to include any error message produced when trying to create the
local UUri.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PLeVasseur