Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider supporting associated new functions which take a UUri struct #78

Open
PLeVasseur opened this issue Aug 16, 2024 · 0 comments
Open

Consider supporting associated new functions which take a UUri struct #78

PLeVasseur opened this issue Aug 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@PLeVasseur
Copy link
Contributor

May just be me 😅 but I like using the UUri::try_from_parts() function from up-rust for creating UUris.

To initialize a UPTransportZenoh I currently have to do that, then convert from the UUri back to a String or &str.

Can we consider supporting associated new functions which take a UUri struct to avoid that little dance?
@PLeVasseur PLeVasseur added the enhancement New feature or request label Aug 16, 2024
sophokles73 added a commit to SoftwareDefinedVehicle/up-transport-zenoh-rust that referenced this issue Oct 8, 2024
@sophokles73
[eclipse-uprotocol#78] Support passing UUri into constructors
264b37f 
The functions for creating a new UPTransportZenoh have been changed
to accept TryInto<UUri> which allows clients to pass in either
strings or UUri structs.
evshary pushed a commit that referenced this issue Oct 8, 2024
@sophokles73
[#78] Support passing UUri into constructors (#84)
3a97fae 
* [#78] Support passing UUri into constructors

The functions for creating a new UPTransportZenoh have been changed
to accept TryInto<UUri> which allows clients to pass in either
strings or UUri structs.

* [#77] Do not swallow UUri conversion error

The functions for creating a new UPTransportZenoh have been changed
to include any error message produced when trying to create the
local UUri.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PLeVasseur