You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HandlerRegistration has two very similar dispatch methods: very confusing.
param handler is used only in 50% cases (MessageConsumerImpl, but not ReplyHandler)
In case of MessageConsumerImpl param handler is the same as MessageConsumerImpl.handler and is only used to protected it from consumer.unregister() during dispatch.
handlerMap.compute can be used instead of merge producing more compact code and without unnecessary (looser) object creation
more comments, better field/variable names, better exception messages
I have made several changes to make the code more compact, readable and understandable.
Heavily tested!
HandlerRegistration
has two very similardispatch
methods: very confusing.handler
is used only in 50% cases (MessageConsumerImpl
, but notReplyHandler
)MessageConsumerImpl
paramhandler
is the same asMessageConsumerImpl.handler
and is only used to protected it fromconsumer.unregister()
during dispatch.handlerMap.compute
can be used instead ofmerge
producing more compact code and without unnecessary (looser) object creationI have made several changes to make the code more compact, readable and understandable.
Heavily tested!
PR:
#4850
(from https://github.com/magicprinc/vert.x/commits/bugfix/compact_args)
Includes Issue #4836 with PR #4847
The text was updated successfully, but these errors were encountered: