Cleanup tests using Java records #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 460 files ±0 6 460 suites ±0 3h 12m 14s ⏱️ + 3m 33s Results for commit aeb4cfd. ± Comparison against base commit 8190316. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
LorenzoBettini
force-pushed
the
lb_3258
branch
from
ef5a71a
to
a0acb0c
Compare
|
@szarnekow I rebased on top of main. |
LorenzoBettini
force-pushed
the
lb_3258
branch
from
a0acb0c
to
49a4a9b
Compare
LorenzoBettini
force-pushed
the
lb_3258
branch
from
49a4a9b
to
aeb4cfd
Compare
|
@cdietrich @szarnekow can I merge? |
cdietrich
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3258
Besides what's described in the issue, I also added Java records to ITs of our Maven plugins, since now we required Java 17. The ITs related to Java 21 are still useful because in those ITs we generate Java 21 bytecode.