New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine encoding of suffix and prefix together into single step #134

Open

Charles-Schleich opened this issue Jun 17, 2024 · 0 comments

Member

Charles-Schleich commented Jun 17, 2024

Describe the feature

The idea would be to take these two fields and rather have them be a bytes/ string representation of the encoding.

.add_field("encoding_suffix", value.encoding.suffix())
.add_field("encoding_prefix", u16::from(encoding.id()))

.add_field("encoding_suffix", value.encoding.suffix())
.add_field("encoding_prefix", u16::from(encoding.id()))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment