Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Commons logging build problem #361

Open
cdietrich opened this issue Sep 27, 2024 · 10 comments
Open

Fix Commons logging build problem #361

cdietrich opened this issue Sep 27, 2024 · 10 comments

Comments

@cdietrich
Copy link
Member

Proposal:

add the new bundle to both target platforms and adjust build.properties files

@cdietrich
Copy link
Member Author

cc @mehmet-karaman

@mehmet-karaman
Copy link
Contributor

With new bundle you mean the jdt xtext facade project?

@cdietrich
Copy link
Member Author

No the new bundle name for commons logging
Check mwe or xtext repo

@mehmet-karaman
Copy link
Contributor

Ok, i am going to try this.

@mehmet-karaman
Copy link
Contributor

started maven build against the two targets in my workspace.. it built succesfully, so are you sure we have to change this?

@cdietrich
Copy link
Member Author

the one against "latest"?

@cdietrich
Copy link
Member Author

i wonder if there is something cached in your local maven repo that is used

@cdietrich
Copy link
Member Author

still failing @mehmet-karaman
does it work on your companys replica of the build?

@mehmet-karaman
Copy link
Contributor

Now it fails also on our replica build.. I've used the full-build.sh file for building.. I didn't checked where we get our dependencies, might be that this repo still had this repository where this old bundle was available.

@mehmet-karaman
Copy link
Contributor

I think I can continue from this.. I will create a PR when its finished.. Thanks..

mehmet-karaman added a commit to mehmet-karaman/Xpect that referenced this issue Sep 30, 2024
mehmet-karaman added a commit to mehmet-karaman/Xpect that referenced this issue Sep 30, 2024
cdietrich added a commit that referenced this issue Sep 30, 2024
…in_dep_prob

#361 fix xpect apache commons logging dependency problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants