Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage Collection in del function, Updated union of lists function #3

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

vijay-jaisankar
Copy link
Contributor

In this PR, the following changes have been implemented:

  • Updated the unionSequence function in ocl.py
  • Added an explicit call to the garbage collection module in the free function of oclfile.py; this should make things a little more efficient.

Copy link
Contributor

@Zishan-Rahman Zishan-Rahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijay-jaisankar (sorry for the ping) The garbage collection code is perfectly fine to merge. However, the unionSequence function is meant to contain duplicates. This mirrors how the union function in Acceleo's implementation of OCL, according to the UML standard, behaves with Sequences. For example, Sequence{'bbb', 'b'}->union({'b', 'bb'}) should evaluate to Sequence{'bbb', 'b', 'b', 'bb'}. If you still want this merged, please can you undo the unionSequence modification and push your changes here so that @kevinlano can merge them (I'm one of his PhD students)?

Copy link
Contributor

@kevinlano kevinlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to oclfile.py is approved, but not to ocl.py

@kevinlano kevinlano merged commit 5349e50 into eclipse-agileuml:master Jan 12, 2025
@vijay-jaisankar
Copy link
Contributor Author

vijay-jaisankar commented Jan 12, 2025

Hello, thanks for the information about the implementation of the OCL. Sure, I can make another commit to this PR if you'd like, reverting the change to the mentioned file.

@Zishan-Rahman
Copy link
Contributor

Zishan-Rahman commented Jan 12, 2025

Hello, thanks for the information about the implementation of the OCL. Sure, I can make another commit to this PR if you'd like, reverting the change to the mentioned file.

@vijay-jaisankar Looks like @kevinlano has already merged this PR just now, so feel free to create another PR reverting the ocl.py union changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants