Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intended use-case for kuksa_val_unittest.yml #610

Closed
erikbosch opened this issue Jul 20, 2023 · 2 comments
Closed

Intended use-case for kuksa_val_unittest.yml #610

erikbosch opened this issue Jul 20, 2023 · 2 comments
Labels
question Further information is requested

Comments

@erikbosch
Copy link
Contributor

We have a workflow kuksa_val_unittest that only runs when we have tagged a commit. That seems quite useless to me, to test after we have tagged. Does it make sense keeping it?

https://github.com/eclipse/kuksa.val/blob/master/.github/workflows/kuksa_val_unittest.yml
https://github.com/eclipse/kuksa.val/actions/workflows/kuksa_val_unittest.yml
@lukasmittag lukasmittag added the question Further information is requested label Jul 21, 2023
@erikbosch
Copy link
Contributor Author

erikbosch commented Jul 26, 2023 •
edited
Loading

I have now disabled https://github.com/eclipse/kuksa.val/actions/workflows/kuksa_val_unittest.yml

We should better decide if w want to delete the workflow+action, or spend the effort to make it running and included in the checks for each PR

@erikbosch
Copy link
Contributor Author

We are about to archive this repo soon. If you consider this issue as important please file a new issue at one of the new Kuksa repos at https://github.com/eclipse-kuksa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikbosch @lukasmittag