Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of kuksa-common - way forward #679

Closed
erikbosch opened this issue Oct 3, 2023 · 2 comments
Closed

Creation of kuksa-common - way forward #679

erikbosch opened this issue Oct 3, 2023 · 2 comments

Comments

@erikbosch
Copy link
Contributor

Background

We have said that we want to split this repo into multiple repos in eclipse-kuksa. As part of https://github.com/eclipse/kuksa.val/wiki/Proposal-for-splitting-of-KUKSA.val it is proposed to create a repo kuksa-common where data typically needed by multiple applications are stored. This issue intends to propose a way forward

Step 1: Copy files to new repo

Step 2: Remove files from kuksa.val and add kuksa-common as submodule

  • Remove all files copied
  • Add kuksa-common as submodule on top level.
  • Adapt build scripts to either use files from the submodule or alternatively use other mechanism like separate clone
  • Acceptance criteria: Tools works as before

Discussion points

  • We have previously discussed removing certs/tokens from default installations, but that seems like a lengthy process so maybe best to first just migrate everything
  • An alternative approach would be to just copy, not remove, and wait with migration until the corresponding components are migrated, but that will make migration somewhat more complex, then there is a risk that certs are just copied.
  • PR createToken.py: Allow specification of the JWT key file and output file #676 mist first be merged/closed
@erikbosch
Copy link
Contributor Author

FYI @SebastianSchildt - I think we should get the migration going, this seems like a reasonable first step but should better be discussed.

@erikbosch
Copy link
Contributor Author

Kuksa-common created, no files removed yet, Proto files still here. I think this one can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant