-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Databroker] Python based integration tests #698
Comments
Sounds good to me, if we can get same (or better) coverage. Maybe @argerus some opinion on this, as I do think the existing integration tests were done by you? |
I'm all for migrating them (and no, I didn't write them). |
Ah, that was @lukasmittag :) WHo meanwhile also tinkered with Cucumber. @lukasmittag would you agree we can get rid of the python based integration tests and achieve the same with cucumber? |
They are mostly testing the sdv.databroker.v1 interface. Cucumber and Gherkin is testing the kuksa.val.v1 interface. So I am leaning on keeping them for now. But it is possible to port them yeah (at a later time maybe). So let's keep this open. |
Is the |
It is "still supported", especially as some user such as Velocitas are usually a lot of versions behind, but we are not modifying it and are putting new improvements/features only in the kuksa.val API. Thus, I would not add support for sdv API in Cucumber tests. However, if the "old" tests are testing the sdv interface, it might be worth to have still around as long as we do have the interface shipped |
Fair enough. Have you already deprecated the |
The integration tests in the
kuksa_databroker/integration_test
seem to provide only very limited coverage. Given that there also is a Cucumber based (integration) test suite, I wonder if it would make sense to migrate the few existing tests to Cucumber so that we do not need to maintain both test suites (including all of the boiler plate helper code around it)?The text was updated successfully, but these errors were encountered: